- Notifications
You must be signed in to change notification settings - Fork302
Upgrade datrie to 0.8+, but not yet for Python 3.8#446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedFeb 26, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #446 +/- ##==========================================+ Coverage 90.60% 90.91% +0.30%========================================== Files 50 50 Lines 6983 6964 -19 Branches 1328 1328 ==========================================+ Hits 6327 6331 +4+ Misses 497 474 -23 Partials 159 159
Continue to review full report at Codecov.
|
gsnedders commentedFeb 29, 2020
see also#455 just dropping it, which I think is what we should do? |
tacaswell commentedMar 26, 2020
datries 0.8.2 supports py38 and was just pushed to pypi |
hugovk commentedMar 26, 2020
Thanks, I've updated this PR to require datrie 0.8.2+ and allow it for any CPython version. I also added Python 3.9-dev to Travis CI to check datrie (and html5lib) is okay there too. |
hugovk commentedMay 28, 2020
No longer needed, re:#455 |
Re:#442.
The latest datrie 0.8 supports Python 3.7:pytries/datrie#52
But it doesn't yet support Python 3.8:pytries/datrie#73