Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Update flake8 to the latest version and fix all errors#428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gsnedders merged 2 commits intohtml5lib:masterfromjdufresne:flake8
Feb 26, 2020
Merged

Update flake8 to the latest version and fix all errors#428

gsnedders merged 2 commits intohtml5lib:masterfromjdufresne:flake8
Feb 26, 2020

Conversation

jdufresne
Copy link
Contributor

No description provided.

@codecov-io
Copy link

codecov-io commentedNov 1, 2019•
edited
Loading

Codecov Report

Merging#428 intomaster willincrease coverage by0.05%.
The diff coverage is66.66%.

Impacted file tree graph

@@            Coverage Diff             @@##           master     #428      +/-   ##==========================================+ Coverage   90.52%   90.57%   +0.05%==========================================  Files          50       50                Lines        6973     6968       -5       Branches     1328     1328              ==========================================- Hits         6312     6311       -1+ Misses        502      498       -4  Partials      159      159
Impacted FilesCoverage Δ
html5lib/tests/tokenizertotree.py0% <ø> (ø)⬆️
html5lib/tests/support.py92.24% <ø> (ø)⬆️
html5lib/treewalkers/etree.py86.07% <ø> (ø)⬆️
html5lib/tests/tree_construction.py93.43% <ø> (ø)⬆️
html5lib/tests/tokenizer.py83.33% <ø> (ø)⬆️
html5lib/_ihatexml.py45.27% <ø> (ø)⬆️
html5lib/_utils.py84.37% <0%> (ø)⬆️
html5lib/_inputstream.py91.92% <100%> (ø)⬆️
html5lib/html5parser.py97.24% <100%> (+0.24%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update7fea68a...72aa36c. Read thecomment docs.

hugovk
hugovk previously approved these changesNov 8, 2019
@hugovk

This comment has been minimized.

@gsnedders
Copy link
Member

FWIW, I have a preference in favour of pinning flake8 and its dependencies to stop tests from starting failing without changes in html5lib, though preferably in combination with adding some bot to update pinned dependencies.

@jdufresne
Copy link
ContributorAuthor

No problem. I've changed the PR to keep flake8 pinned, but now to the latest version. All errors are still fixed.

@hugovk
Copy link
Contributor

preferably in combination with adding some bot to update pinned dependencies.

The two bots I know about: dependabot, now part of GitHub; and pyupbot, which I hear has been a bit flaky of late.

@jdufresnejdufresne changed the titleUnpin flake8 and fix all errorsUpdate flake8 to the latest version and fix all errorsFeb 25, 2020
@gsnedders
Copy link
Member

Yeah, we use pyupbot on web-platform-tests and it seems to have been going downhill…

The exception is caught and always re-raised without any additionalaction. Simply let the original exception bubble up instead.
@gsneddersgsnedders merged commit986560a intohtml5lib:masterFeb 26, 2020
@jdufresnejdufresne deleted the flake8 branchFebruary 26, 2020 01:22
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gsneddersgsneddersgsnedders approved these changes

@hugovkhugovkhugovk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jdufresne@codecov-io@hugovk@gsnedders
[8]ページ先頭
©2009-2025 Movatter.jp