Allow data: to not be part of sanitizer’s allowed protocols#412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

charmander wants to merge1 commit intohtml5lib:master

base:master

Choose a base branch

fromcharmander:patch-1

Open

Allow data: to not be part of sanitizer’s allowed protocols#412

charmander wants to merge1 commit intohtml5lib:masterfromcharmander:patch-1

Conversation

Copy link

charmander commentedFeb 21, 2019

Whendata: wasn’t permitted, it could attempt todel attrs[attr] twice.

Allow data: to not be part of sanitizer’s allowed protocols

e4757eb

When `data:` wasn’t permitted, it could attempt to `del attrs[attr]` twice.

Copy link

codecov-io commentedFeb 21, 2019•
edited
Loading

Codecov Report

Merging#412 intomaster willnot change coverage.
The diff coverage is100%.

@@           Coverage Diff           @@##           master     #412   +/-   ##=======================================  Coverage   90.79%   90.79%           =======================================  Files          50       50             Lines        6952     6952             Branches     1328     1328           =======================================  Hits         6312     6312             Misses        481      481             Partials      159      159

Impacted Files	Coverage Δ
html5lib/filters/sanitizer.py	`93.16% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4f92357...e4757eb. Read thecomment docs.