Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add testing and document support for Python 3.7 & PyPy3#409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gsnedders merged 1 commit intohtml5lib:masterfromjdufresne:py37
Feb 26, 2020
Merged

Add testing and document support for Python 3.7 & PyPy3#409

gsnedders merged 1 commit intohtml5lib:masterfromjdufresne:py37
Feb 26, 2020

Conversation

jdufresne
Copy link
Contributor

Python 3.7 was released on June 27, 2018.

https://docs.python.org/3/whatsnew/3.7.html

Use 'dist: xenial' in Travis to allow using Python version 3.7. Travis
officially added support for Xenial on 2018-11-08.

https://blog.travis-ci.com/2018-11-08-xenial-release

hugovk reacted with thumbs up emoji
@jdufresne
Copy link
ContributorAuthor

Looks like the optional package datrie doesn't build with Python 3.7:

pytries/datrie#52

@jdufresne
Copy link
ContributorAuthor

Perhaps support for datrie should be dropped or limited to Python <=3.6. The upstream package looks unmaintained and is not releasing new versions.

@twmtwm mentioned this pull requestMar 5, 2019
@codecov-io
Copy link

codecov-io commentedOct 17, 2019•
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@986560a).Click here to learn what that means.
The diff coverage isn/a.

Impacted file tree graph

@@            Coverage Diff            @@##             master     #409   +/-   ##=========================================  Coverage          ?   90.52%           =========================================  Files             ?       50             Lines             ?     6973             Branches          ?     1328           =========================================  Hits              ?     6312             Misses            ?      502             Partials          ?      159

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update986560a...8521a87. Read thecomment docs.

@jdufresne
Copy link
ContributorAuthor

Thanks for the review, I've made the suggested changes.

hugovk
hugovk previously approved these changesOct 18, 2019
@jdufresne
Copy link
ContributorAuthor

The Python 3.8 CI failures are due to flake8 and fixed in#428.

hugovk
hugovk previously approved these changesNov 8, 2019
@hugovk

This comment has been minimized.

Python 3.7 was released on June 27, 2018.Python 3.8 was released on October 14th, 2019.
@gsnedders
Copy link
Member

#417 added Python 3.7 testing and made the datrie support conditional on < 3.7, though see#442.

@gsneddersgsnedders merged commit6c21db2 intohtml5lib:masterFeb 26, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@gsneddersgsneddersgsnedders approved these changes

@hugovkhugovkhugovk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jdufresne@codecov-io@hugovk@gsnedders
[8]ページ先頭
©2009-2025 Movatter.jp