html5lib/html5lib-pythonPublic

NotificationsYou must be signed in to change notification settings
Fork294
Star1.2k

Try to import Mapping and MutableMapping from collections.abc#403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gsnedders merged 1 commit intohtml5lib:masterfrom5j9:master

Oct 1, 2018

Merged

Try to import Mapping and MutableMapping from collections.abc#403

gsnedders merged 1 commit intohtml5lib:masterfrom5j9:master

Oct 1, 2018

Conversation

Copy link

Contributor

5j9 commentedSep 23, 2018

Note that collections.abc has been added in Python 3.3.

Fixes#402

Try to import MutableMapping from collections.abc

322a2d5

Note that collections.abc has been added in Python 3.3.Fixeshtml5lib#402

5j9 force-pushed themaster branch from9d53c9c to322a2d5Compare

September 23, 2018 08:20

Copy link

codecov-io commentedSep 23, 2018•
edited
Loading

Codecov Report

Merging#403 intomaster willincrease coverage by<.01%.
The diff coverage is100%.

@@            Coverage Diff             @@##           master     #403      +/-   ##==========================================+ Coverage   90.76%   90.77%   +<.01%==========================================  Files          50       50                Lines        6950     6956       +6       Branches     1328     1328              ==========================================+ Hits         6308     6314       +6  Misses        483      483                Partials      159      159

Impacted Files	Coverage Δ
html5lib/_trie/_base.py	`61.53% <100%> (+5.01%)`	⬆️
html5lib/treebuilders/dom.py	`89.41% <100%> (+0.19%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update950ea0e...322a2d5. Read thecomment docs.

5j9 changed the title~~Try to import MutableMapping from collections.abc~~Try to import Mapping and MutableMapping from collections.abc

Sep 23, 2018

gsnedders approved these changes

Oct 1, 2018

View reviewed changes

Copy link

Member

gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for fixing this!

gsnedders merged commit4f92357 intohtml5lib:master

Oct 1, 2018

tirkarthi mentioned this pull request

Dec 20, 2018

bpo-25988: Do not expose abstract collection classes in the collections module.python/cpython#10596

Merged

Copy link

astrojuanlu commentedJan 29, 2019

Would be great to have a release shipping this among the other improvements!

inirudebwoy mentioned this pull request

Apr 10, 2019

Added tests and refactorized codemar123zaj/Web-Crawler#1

Merged

pganssle mentioned this pull request

May 18, 2019

New release on PyPI?#419

Closed

eli-schwartz mentioned this pull request

Oct 27, 2019

Fix collections imports for Python 3.8#408

Closed

Copy link

pllim commentedNov 8, 2019

Still no release with this patch after a year? 😢

Copy link

zsol commentedDec 20, 2019•
edited
Loading

Edit: apologies for the noise, there's already discussion happening about this in#419.

This is now breaking with Python 3.9:

❯ pythonPython 3.9.0a2+ (heads/master:b0d4949, Dec 20 2019, 11:38:30)[GCC 8.3.0] on linuxType "help", "copyright", "credits" or "license" for more information.>>> import html5libTraceback (most recent call last):  File "<stdin>", line 1, in <module>  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/__init__.py", line 25, in <module>    from .html5parser import HTMLParser, parse, parseFragment  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/html5parser.py", line 8, in <module>    from . import _tokenizer  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_tokenizer.py", line 16, in <module>    from ._trie import Trie  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/__init__.py", line 3, in <module>    from .py import Trie as PyTrie  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/py.py", line 6, in <module>    from ._base import Trie as ABCTrie  File "/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/site-packages/html5lib/_trie/_base.py", line 3, in <module>    from collections import MappingImportError: cannot import name 'Mapping' from 'collections' (/home/pi/.pyenv/versions/3.9-dev/lib/python3.9/collections/__init__.py)