- Notifications
You must be signed in to change notification settings - Fork294
Add support for <ol reversed>, related attributes#396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Mark <ol reversed> as a boolean attribute so it serializes properly in HTML.* Allow <ol reversed> in the sanitizer.Closeshtml5lib#321.* Allow <ol start> in the sanitizer.* <ol type> was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future.https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed
twm added a commit to twm/html5lib-python that referenced this pull requestJun 10, 2018
It looks like this was missed inhtml5lib#358. It is causing build failures inhtml5lib#395 andhtml5lib#396.
gsnedders pushed a commit that referenced this pull requestOct 1, 2018
codecov-io commentedOct 7, 2018 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #396 +/- ##=========================================+ Coverage 90.79% 90.8% +0.01%========================================= Files 50 50 Lines 6952 6964 +12 Branches 1328 1328 =========================================+ Hits 6312 6324 +12 Misses 481 481 Partials 159 159
Continue to review full report at Codecov.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<ol reversed>
as a boolean attribute so it serializes properly in HTML.<ol reversed>
in the sanitizer.ClosesSanitizer removes the <ol> "reversed" attribute #321.<ol start>
in the sanitizer.<ol type>
was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future.https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed