Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for <ol reversed>, related attributes#396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ambv merged 4 commits intohtml5lib:masterfromtwm:ol-reversed
Mar 3, 2023

Conversation

twm
Copy link
Contributor

@twmtwm commentedJun 10, 2018

  • Mark<ol reversed> as a boolean attribute so it serializes properly in HTML.
  • Allow<ol reversed> in the sanitizer.ClosesSanitizer removes the <ol> "reversed" attribute #321.
  • Allow<ol start> in the sanitizer.
  • <ol type> was already allowed, but probably accidentally (type is an attribute allowed for other tags). I added a test to prevent it from regressing in case we add per-element attribute sanitization in the future.

https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed

* Mark <ol reversed> as a boolean attribute so it serializes properly in  HTML.* Allow <ol reversed> in the sanitizer.Closeshtml5lib#321.* Allow <ol start> in the sanitizer.* <ol type> was already allowed, but probably accidentally (type is an  attribute allowed for other tags). I added a test to prevent it from  regressing in case we add per-element attribute sanitization in the  future.https://html.spec.whatwg.org/multipage/grouping-content.html#attr-ol-reversed
twm added a commit to twm/html5lib-python that referenced this pull requestJun 10, 2018
It looks like this was missed inhtml5lib#358. It is causing build failures inhtml5lib#395 andhtml5lib#396.
gsnedders pushed a commit that referenced this pull requestOct 1, 2018
It looks like this was missed in#358. It is causing build failures in#395 and#396.
@codecov-io
Copy link

codecov-io commentedOct 7, 2018
edited
Loading

Codecov Report

Merging#396 intomaster willincrease coverage by0.01%.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##           master    #396      +/-   ##=========================================+ Coverage   90.79%   90.8%   +0.01%=========================================  Files          50      50                Lines        6952    6964      +12       Branches     1328    1328              =========================================+ Hits         6312    6324      +12  Misses        481     481                Partials      159     159
Impacted FilesCoverage Δ
html5lib/filters/sanitizer.py93.16% <ø> (ø)⬆️
html5lib/constants.py100% <ø> (ø)⬆️
html5lib/tests/test_sanitizer.py95.34% <100%> (+0.75%)⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4f92357...4b34642. Read thecomment docs.

@ambvambv merged commit01b7dea intohtml5lib:masterMar 3, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sanitizer removes the <ol> "reversed" attribute
4 participants
@twm@codecov-io@ambv@gsnedders

[8]ページ先頭

©2009-2025 Movatter.jp