Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Speed up CI#385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
willkg merged 1 commit intohtml5lib:masterfromhugovk:speedup-ci
Dec 4, 2017
Merged

Speed up CI#385

willkg merged 1 commit intohtml5lib:masterfromhugovk:speedup-ci
Dec 4, 2017

Conversation

hugovk
Copy link
Contributor

It's usually quicker to have the slower build jobs run first, that way the build isn't waiting as at the end for one or two slow ones to cmoplete.

Taking numbers from a master build, rounding to nearest minutes, gives something like this in theory for five parallel jobs:

xxxxxxxxxxxxxxx  xxx   xxxx   xxx   xxx    xxx     xx      xx      xx       xx       xxx       xxx        xxx        xxx         xxxxxxx          xxxxxxxxx          xxxxxxxxx1234567890123456789

In reality:

Slowest first, using same numbers:

xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx   xxx   xx     xx      xxx       xxx       xx         xx         xxxx         xxx         xxx          xxx           xxx            xxx            xxx             xx             xxxx12345678901234567

This PR build:

@codecov-io
Copy link

codecov-io commentedDec 4, 2017
edited
Loading

Codecov Report

Merging#385 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #385   +/-   ##=======================================  Coverage   90.76%   90.76%           =======================================  Files          50       50             Lines        6950     6950             Branches     1328     1328           =======================================  Hits         6308     6308             Misses        483      483             Partials      159      159

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef7708c4...0dcbd68. Read thecomment docs.

@willkg
Copy link
Contributor

I looked at the master builds for the last 10 rounds and the numbers are kind of all over the place and not consistent. So I'm not sure I see evidence that this will really improve the situation.

The specific change here is just reordering the environments which is benign, so I'm going to approve it and land it and we can see how future builds affect the hypothesis.

hugovk reacted with thumbs up emoji

@willkgwillkg merged commit41bd598 intohtml5lib:masterDec 4, 2017
@hugovkhugovk deleted the speedup-ci branchDecember 4, 2017 13:57
@hugovk
Copy link
ContributorAuthor

For reference, here's the last 10 passing master builds (685-711), latest first:

Ran for 20 min 45 sec
Ran for 26 min 58 sec
Ran for 22 min 12 sec
Ran for 24 min 32 sec
Ran for 17 min 33 sec
Ran for 19 min 5 sec
Ran for 23 min 14 sec
Ran for 16 min 15 sec
Ran for 17 min 58 sec
Ran for 14 min 58 sec

@willkgwillkg added this to the1.0 milestoneDec 4, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@willkgwillkgwillkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.

3 participants
@hugovk@codecov-io@willkg

[8]ページ先頭

©2009-2025 Movatter.jp