Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update CHANGES.rst#384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
willkg merged 1 commit intohtml5lib:masterfromhugovk:update-changes
Dec 4, 2017
Merged

Update CHANGES.rst#384

willkg merged 1 commit intohtml5lib:masterfromhugovk:update-changes
Dec 4, 2017

Conversation

hugovk
Copy link
Contributor

@hugovkhugovk changed the titleList PRs merged since 2016-07-15Update CHANGES.rstDec 4, 2017
@codecov-io
Copy link

codecov-io commentedDec 4, 2017
edited
Loading

Codecov Report

Merging#384 intomaster willnot change coverage.
The diff coverage isn/a.

Impacted file tree graph

@@           Coverage Diff           @@##           master     #384   +/-   ##=======================================  Coverage   90.76%   90.76%           =======================================  Files          50       50             Lines        6950     6950             Branches     1328     1328           =======================================  Hits         6308     6308             Misses        483      483             Partials      159      159

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update41bd598...6263ec1. Read thecomment docs.

Copy link
Contributor

@willkgwillkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This file gets put into the docs and one of the goals I want for it is for users to look at the list of changes and understand how it affects them when they upgrade. This list isn't helpful in that way.

Workflow-wise, it's easier for me to approve your changes and this is a helpful start, so let me write up a comment for this PR that's more along the lines of what I'm thinking of.

@hugovk
Copy link
ContributorAuthor

Makes sense.

In general, in future, I'd recommend updating the file as you go along.

Not sure how much this applies to a 1.0 release (probably not at all!), but it may be useful to group things from a SemVer point of view, e.g.

API Changes

  • a

API Additions

  • b

Other Changes

  • c

@willkg
Copy link
Contributor

I want to do something like that, but with headers: "Breaking changes", "Features", "Bug fixes".

In my experience maintaining projects, I've found it's easier to do a rollup at the end just before the release rather than have to deal with getting all the contributors to update the changelog and do it in a way that matches existing releases. I decided that's what I'll do here. Future maintainers can do as they like.

I do appreciate the outline you did, though. That helps a ton!

hugovk and jwhitlock reacted with thumbs up emoji

@willkg
Copy link
Contributor

How about something like this?:

Breaking changes:* Drop support for Python 2.6. (#330) (Thank you, Hugo, Will Kahn-Greene!)* Remove ``utils/spider.py`` (#353) (Thank you, Jon Dufresne!)Features:* Improve documentation. (#300, #307) (Thank you, Jon Dufresne, Tom Most,  Will Kahn-Greene!)* Add iframe seamless boolean attribute. (Thank you, Ritwik Gupta!)* Add itemscope as a boolean attribute. (#194) (Thank you, Jonathan Vanasco!)* Support Python 3.6. (#333) (Thank you, Jon Dufresne!)* Add CI support for Windows using AppVeyor. (Thank you, John Vandenberg!)* Improve testing and CI and add code coverage (#323, #334), (Thank you, Jon  Dufresne, John Vandenberg, Geoffrey Sneddon, Will Kahn-Greene!)* Semver-compliant version number.Bug fixes:* Add support for setuptools < 18.5 to support environment markers. (Thank you,  John Vandenberg!)* Add explicit dependency for six >= 1.9. (Thank you, Eric Amorde!)* Fix regexes to work with Python 3.7 regex adjustments. (#318, #379) (Thank  you, Benedikt Morbach, Ville Skyttä, Mark Vasilkov!)* Fix alphabeticalattributes filter namespace bug. (#324) (Thank you, Will  Kahn-Greene!)* Include license file in generated wheel package. (#350) (Thank you, Jon  Dufresne!)* Fix annotation-xml typo. (#339) (Thank you, Will Kahn-Greene!)* Allow uppercase hex chararcters in CSS colour check. (#377) (Thank you,  Hugo!)

I think that's sufficiently helpful for users to understand what the changes mean for them. It adds "thank you!" bits for all the people who worked on changes. It adds some/most of the relevant issue numbers.

How does that look?

@hugovk
Copy link
ContributorAuthor

Looks good. The original uppercase hex author should get credit too, and in AUTHORS.

@willkg
Copy link
Contributor

@hugovk Can you make those changes to this PR? Then I can review and land it. Thank you!

@hugovk
Copy link
ContributorAuthor

@willkg Done!

Copy link
Contributor

@willkgwillkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yay--thank you!

@willkgwillkg merged commit4ed8b8b intohtml5lib:masterDec 4, 2017
@hugovkhugovk deleted the update-changes branchDecember 4, 2017 23:01
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@willkgwillkgwillkg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update CHANGES.rst and AUTHORS.rst for 1.0 release
3 participants
@hugovk@codecov-io@willkg

[8]ページ先頭

©2009-2025 Movatter.jp