- Notifications
You must be signed in to change notification settings - Fork294
First pass at documenting html5lib.filters#375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@gsnedders,@jgraham Can one of you review this, please? |
codecov-io commentedNov 29, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #375 +/- ##======================================= Coverage 90.76% 90.76% ======================================= Files 50 50 Lines 6950 6950 Branches 1328 1328 ======================================= Hits 6308 6308 Misses 483 483 Partials 159 159
Continue to review full report at Codecov.
|
html5lib/filters/whitespace.py Outdated
| @@ -10,7 +10,7 @@ | |||
| class Filter(base.Filter): | |||
| """Collapses whitespace except in pre and textarea tags""" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Elements, not tags. Also it's more than just pre and textarea; I think script is in rcdataElements too.
^^^@gsnedders Does that fix the issue? I sort of understand it, but I'm not sure I know enough to know if it's completely fixed or not. |
@gsnedders Can you review this please? |
Thank you! |
This covers
html5lib.filtersin issue#307.Is this documentation for filters clear enough for a 1.0?