- Notifications
You must be signed in to change notification settings - Fork294
Pin pytest to a version that doesn't require six#372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Pretty sure this gets around the problem that prompted issue#370. Though we should do that as well at some point. @gsnedders When Travis and AppVeyor are happy, can you review this? |
There's another PR that fixes That's the root cause of the AppVeyor failure. |
Fyi, I'll be able to help in about 15 mins. …On Wed, 29 Nov 2017 08:02 Will Kahn-Greene ***@***.***> wrote: There's another PR that fixes tox.ini to use requirements-test.txt. I could pull that change into this one, but then that one will require more work to merge. I'm inclined to leave this as is and let that one fix tox.ini. That's the root cause of the AppVeyor failure. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#372 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAA69PhwjMbOvoXKFnMvxVuwd3sYjsMRks5s7K0LgaJpZM4QuOx6> . |
I've rebased & fixed my PR (#364), and if you rebase this PR on top of mine, I think everything should be green. |
PR#364 pins pytest now. I'm going to close this PR out. |
Uh oh!
There was an error while loading.Please reload this page.
pytest 3.3.0 added
six>=1.10.0as a requirement which messes us up. Either we should drop support for six 1.9 or we can land this which pins pytest to a slightly earlier version as a stopgap.