- Notifications
You must be signed in to change notification settings - Fork294
Add AppVeyor testing#359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
After we land this, we need to set up appveyor as a CI thing, right? Is there anything else we need to do? |
Not mandatory; devs can just do it on their forks if you're not keen on it being part of the PR process. I've chosen to use |
@willkg lmk if I need to do anything to enable AppVeyor on the repo! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This looks good to me! Thank you!
@jayvdb Naming the file that is fine by me. I want this to be part of the PR process. I'll figure out whether I can add it on my own and if not, ping@gsnedders for help. Thank you! |
gsnedders commentedNov 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Now added.https://ci.appveyor.com/project/gsnedders/html5lib-python/build/1.0.1 ran this as landed. |
@gsnedders Thank you! |
This is the first subset of#293 .