Fix Travis CI builds on Python 3.4#352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

willkg merged 1 commit intohtml5lib:masterfromjdufresne:fix-test-failures

Oct 31, 2017

Merged

Fix Travis CI builds on Python 3.4#352

willkg merged 1 commit intohtml5lib:masterfromjdufresne:fix-test-failures

Oct 31, 2017

Conversation

Copy link

Contributor

jdufresne commentedOct 28, 2017•
edited
Loading

Avoid passing-U topip install commands. It causes the six package to upgrade, which fails on the Travis 3.4 image. I cannot reproduce this locally, so I'm left to conclude that the Travis Python 3.4 image is corrupt in some way. The installed six package is perfectly fine for testing, so use it without upgrading. All builds now pass.

Install six package first to avoid upgrading it then downgrading it in some test configurations.

Fix Travis CI builds on Python 3.4

74ebfc9

Avoid passing -U to pip install commands. It causes the six package toupgrade, which fails on the Travis 3.4 image. I cannot reproduce thislocally, so I'm left to conclude that the Travis Python 3.4 image iscorrupt in some way. The installed six package is perfectly fine fortesting, so use it without upgrading. All builds now pass.Install six package first to avoid upgrading it then downgrading it insome test configurations.