Give minimum versions of all dependencies and test on them#320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

gsnedders wants to merge6 commits intohtml5lib:masterfromgsnedders:dep_versions

Closed

Give minimum versions of all dependencies and test on them#320

gsnedders wants to merge6 commits intohtml5lib:masterfromgsnedders:dep_versions

Conversation

Copy link

Member

gsnedders commentedFeb 19, 2017

No description provided.

gsnedders added6 commits

February 19, 2017 23:16

Declare min/max versions of all our dependencies

54f03df

Test on min versions of all deps, not just six

7bfff48

Add Python 3.6 to the test matrix

ee92ee2

fixup! Test on min versions of all deps, not just six

7df5bd3

fixup! Test on min versions of all deps, not just six

45863e2

fixup! Test on min versions of all deps, not just six

8d18acf

Copy link

MemberAuthor

gsnedders commentedMar 17, 2017

This doesn't work becausePIP_VERSION is consumed by PIP. Need to rename the env variable.

willkg added this to the1.0 milestone

Oct 3, 2017

Copy link

Contributor

willkg commentedOct 31, 2017

I understand the gist of what this is trying to solve, but I think this is better solved with tox and environment matrixes.

I think we should close this out and reimplement it after the PR switching to tox has landed.

Regardless, I'm taking this out of the 1.0 milestone.

willkg removed this from the1.0 milestone

Oct 31, 2017

Copy link

Member

ambv commentedMar 3, 2023

It would be nice to test the minimum versions of dependencies that we support. Luckily, there really only issix andwebencodings that are required.six will go away when Python 2 support is gone.

However, we should NOT be pinningmaximum versions as overly restrictive version caps cannot be fixed by the user. See:https://iscinumpy.dev/post/bound-version-constraints/

In any case, this PR is quite outdated. I'll make a new one to declare minimum versions of all dependencies that we still use inmaster.