Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Fix spider#294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
jayvdb wants to merge3 commits intohtml5lib:masterfromjayvdb:fix-spider
Closed

Fix spider#294

jayvdb wants to merge3 commits intohtml5lib:masterfromjayvdb:fix-spider

Conversation

jayvdb
Copy link
Contributor

@jayvdbjayvdb commentedJul 28, 2016•
edited
Loading

No description provided.

spider.py used both Python 2-only (md5) and Python 3-only (urllib) imports.Also, it didnt use a namespace when searching for links to spider,and did not read the robots.txt, preventing any spidering occurring.Fix exception occuring when robots processing removed items fromlist toVisit while iterating over the list.Add more output on stderr, and a main() which spiders yahoo.com
@jayvdb
Copy link
ContributorAuthor

We could probably replace most of this with an existing library.

@jayvdbjayvdb mentioned this pull requestJul 28, 2016
@Ms2ger
Copy link
Contributor

Can we usesix for theurllib imports?

@jayvdb
Copy link
ContributorAuthor

jayvdb commentedAug 5, 2016•
edited
Loading

Usingsix here looks good; I checked and it providesrobotparser, since 2013 (https://bitbucket.org/gutworth/six/pull-requests/5/create-sixmovesurllib/diff /https://bitbucket.org/gutworth/six/commits/1f2c7f5d14be9027d180aa00138a1d29c8f48a6f), released as six 1.4.0 .
Should I find a minimum version for six support? Currently it doesnt have one.

@gsnedders
Copy link
Member

As far as I'm aware, nobody's actually run it for years hence it being badly broken. We should probably just kill it at this point, as it likely has no real use.

@willkgwillkg mentioned this pull requestOct 3, 2017
@willkg
Copy link
Contributor

Given the previous comment, I'm going to close this out. I opened#349 to cover removingutils/spider.py.

@willkgwillkg closed thisOct 3, 2017
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@jayvdb@Ms2ger@gsnedders@willkg
[8]ページ先頭
©2009-2025 Movatter.jp