This tries to address#231 again, reverting to platform_python_implementation. This should work everywhere with setuptools 18.5 above; see#231 for more discussion of this.

Copy link

codecov-io commentedJun 6, 2016•
edited
Loading

Current coverage is90.48%

Merging#263 intomaster will decrease coverage by0.30%

@@             master       #263   diff @@==========================================  Files            51         51            Lines          6857       6840    -17     Methods           0          0            Messages          0          0            Branches       1317       1291    -26   ==========================================- Hits           6225       6189    -36- Misses          472        485    +13- Partials        160        166     +6

Powered byCodecov. Last updated by5197f55...192a058

gsnedders modified the milestone:0.99999999

Jun 6, 2016

Copy link

MemberAuthor

gsnedders commentedJun 6, 2016

Hmm, maybe shouldn't run with loads of setuptools versions…

gsnedders force-pushed thefix_setuptools_fun branch frombf37228 to1fab9fdCompare

June 6, 2016 21:00

gsnedders added3 commits

June 6, 2016 22:51

Make sure setup.py works regardless of cwd

d5b0dc2

Try fixinghtml5lib#231again: Return to using platform_python_implem…

21aabd6

…entationThis makes us require setuptools>=18.5

Give a more useful error message than a SyntaxError on old setuptools

c562f28

gsnedders force-pushed thefix_setuptools_fun branch from1fab9fd toc562f28Compare

June 6, 2016 21:51

gsnedders merged commitfbce67d intohtml5lib:master

Jun 6, 2016

gsnedders deleted the fix_setuptools_fun branch

June 6, 2016 22:00

Copy link

jraby commentedJul 18, 2016

For the record, checking version of setuptools in the body ofsetup.py in this manner makes it impossible to install/upgrade setuptools at the same time as html5lib.

For example this fails:

cat >req.txt <<EOFsetuptools>=18.5html5libEOFvirtualenv testenvtestenv/bin/pip install -r req.txtCollecting setuptools>=18.5 (from -r req.txt (line 1))  Using cached setuptools-24.0.3-py2.py3-none-any.whlCollecting html5lib (from -r req.txt (line 2))  Using cached html5lib-0.999999999.tar.gz    Complete output from command python setup.py egg_info:    html5lib requires setuptools version 18.5 or above; please upgrade before installing (you have 18.2)    ----------------------------------------Command "python setup.py egg_info" failed with error code 1 in /private/var/folders/49/p3xmv77x6fnb2lwl5kpvmvs40000gp/T/pip-build-0vYISn/html5libYou are using pip version 7.1.2, however version 8.1.2 is available.You should consider upgrading via the 'pip install --upgrade pip' command.