Refactor sanitize_token for better subclassing#26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mfa wants to merge3 commits intohtml5lib:masterfrommfa:master

Closed

Refactor sanitize_token for better subclassing#26

mfa wants to merge3 commits intohtml5lib:masterfrommfa:master

Conversation

Copy link

Contributor

mfa commentedApr 24, 2013

For my application I need to clean all unallowed tokens.
At the moment the only way is to copy the whole sanitize_token method, remove a few lines and add one.
Splitting up the sanitize_token method would simplify this a lot and reduces code duplication (in my code).

Example usage:

importhtml5libfromhtml5libimporttreebuilders,treewalkers,serializer,sanitizerclassMySanitizer(sanitizer.HTMLSanitizer):# reduce tokens to only a fewacceptable_elements= ['b','br','center','em','h3','h4','h5','h6','i','li','ol','p','span','strike','strong','tt','ul']allowed_elements=acceptable_elementsdefunallowed_token(self,token):# remove all unallowed tokensreturn""defsanitize(input):p=html5lib.HTMLParser(tokenizer=MySanitizer,tree=treebuilders.getTreeBuilder("dom"))dom_tree=p.parseFragment(input)walker=treewalkers.getTreeWalker("dom")stream=walker(dom_tree)s=serializer.htmlserializer.HTMLSerializer(omit_optional_tags=False,quote_attr_values=True)returnu"".join(s.serialize(stream))

refactor allowed_token and unallowed_token as new methods in HTMLSani…

496e69f

…tizerMixin for usage in subclass.

Copy link

Member

gsnedders commentedApr 24, 2013

Well, Travis CI shows you having made all the sanitizer tests fail. That ought to be fixed. Otherwise, you should use the standard English "disallow" and not "unallow". That said, in principle looks good.