- Notifications
You must be signed in to change notification settings - Fork294
Allow self closing <col /> tags.#244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedMay 7, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Current coverage is90.79%@@ master #244 diff @@========================================== Files 51 51 Lines 6857 6864 +7 Methods 0 0 Messages 0 0 Branches 1317 1317 ==========================================+ Hits 6225 6232 +7 Misses 472 472 Partials 160 160
|
Any chance this could be reviewed and integrated? All feedback is welcome. I'm happy to work on the PR to meet any project standards. |
@jdufresne Sorry for both failing to respond to this initially and that comment! In short, I'm trying to push out a release quickly with most of the API changes, and then trying to deal with parser changes after that. This rather got shoved into the latter category, for not really any good reason given it's a relatively small change… |
| @@ -46,6 +46,8 @@ Released on XXX | |||
| * **Drop support of charade, now that chardet is supported once more.** | |||
| * Added support for self closing ``<col />`` tags. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In general, we keep small changes out of the changes file. (Does the contributing doc say that? If not, bah! That really should've been caught before now…)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Removed from changes.
Thanks for the guidance, that change worked! All additional feedback welcome. |
Awesome, at quick glance that looks fine, will take a closer look later. Thanks! |
No description provided.