Scripting disabled case#243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

gsnedders merged 2 commits intohtml5lib:masterfromgsnedders:noscript

May 11, 2016

Merged

Scripting disabled case#243

gsnedders merged 2 commits intohtml5lib:masterfromgsnedders:noscript

May 11, 2016

Conversation

Copy link

Member

gsnedders commentedMay 7, 2016•
edited
Loading

This essentially rebases#230 as well as squashing it, and fixes tree walker tests to set the scripting flag correctly. Stillfixes#10. //cc@neumond

Copy link

codecov-io commentedMay 7, 2016•
edited
Loading

Current coverage is89.22%

Merging#243 intomaster will decrease coverage by-<.01%

@@             master       #243   diff @@==========================================  Files            50         50            Lines          6731       6774    +43     Methods           0          0            Messages          0          0            Branches       1313       1317     +4   ==========================================+ Hits           6006       6044    +38- Misses          555        560     +5  Partials        170        170

Powered byCodecov. Last updated by911cf45...a3207b0

Copy link

MemberAuthor

gsnedders commentedMay 7, 2016

So we don't have tests for "in head noscript" insertion mode, that kinda sucks.

Copy link

MemberAuthor

gsnedders commentedMay 7, 2016

Also:

(py2-env)pnin:html5lib-python gsnedders$ python parse.py foo.html Traceback (most recent call last):  File "parse.py", line 97, in run    document = parseMethod(f, encoding=encoding)  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 239, in parse    parseMeta=parseMeta, useChardet=useChardet, scripting=scripting)  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 94, in _parse    self.mainLoop()  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 217, in mainLoop    reprocess = self.phase.processEOF()  File "/Users/gsnedders/Documents/my-projects/html5lib/html5lib-python/html5lib/html5parser.py", line 469, in processEOF    raise NotImplementedErrorNotImplementedError(py2-env)pnin:html5lib-python gsnedders$ cat foo.html <head><noscript></head>

Copy link

Contributor

neumond commentedMay 7, 2016

Looks good to me.

gsnedders mentioned this pull request

May 7, 2016

Implement inhead-noscript context, add script parameter to parse#230

Closed

Copy link

codecov-io commentedMay 7, 2016•
edited
Loading

Current coverage is89.13%

Merging#243 intomaster will decrease coverage by-0.10%

@@             master       #243   diff @@==========================================  Files            50         50            Lines          6739       6796    +57     Methods           0          0            Messages          0          0            Branches       1314       1318     +4   ==========================================+ Hits           6013       6057    +44- Misses          556        569    +13  Partials        170        170