Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implement inhead-noscript context, add script parameter to parse#230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
neumond wants to merge3 commits intohtml5lib:masterfromneumond:master
Closed

Conversation

neumond
Copy link
Contributor

48 failing tests now pass.#script-on and#script-off parameters are now considered in testing.

@codecov-io
Copy link

Current coverage is89.41%

Branch#230 has no coverage reports uploaded yet.

No diff could be generated. No reports formaster found.

Powered byCodecov. Updated on successful CI builds.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.13% when pulling70151d2 on neumond:master intod999875 on html5lib:master.

@neumond
Copy link
ContributorAuthor

Looks like something unrelated started to selectively fail or pass depending on version of python.

@@ -22,18 +22,18 @@


def parse(doc, treebuilder="etree", encoding=None,
namespaceHTMLElements=True):
namespaceHTMLElements=True, script=True):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Bikeshed moment: Can we call thisscripting?

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Not a problem. I had doubts naming it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Also, I'd rather we default to False, given we don't actually implement scripting.

@gsnedders
Copy link
Member

@neumond Thanks, this looks great! I've nothing but a few nits to complain about. :)

I'll try and have a look at why it's failing on Travis soon, FWIW.

(Also: this fixes#10.)

@gsnedders
Copy link
Member

@neumond: one hypothesis about the Travis failures: try recreating the expectation file on Python 2.7 (with optional extras installed).

neumond reacted with thumbs up emoji

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.13% when pulling969d7c6 on neumond:master intod999875 on html5lib:master.

@neumond
Copy link
ContributorAuthor

@gsnedders You were right, tests with cElementTree were not masked under py3. Thanks for solving pytest-expect py2/py3 issues in advance.

@gsnedders
Copy link
Member

@neumond I'll try and add a warning or error if you're updating the tests with the wrong config, given that's totally undocumented and even I'd forgotten what exactly was needed.

@gsnedders
Copy link
Member

@neumond Oh, I hadn't noticed before, but: can you move the option toHTMLParser.__init__ from_parse? Also,test_treewalker.py needs updated to enable/disable scripting.

@gsnedders
Copy link
Member

Why did I think that a good idea? No,_parse is the right place.

@gsneddersgsnedders mentioned this pull requestMay 7, 2016
@gsnedders
Copy link
Member

Superseded by#243.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@neumond@codecov-io@landscape-bot@gsnedders
[8]ページ先頭
©2009-2025 Movatter.jp