- Notifications
You must be signed in to change notification settings - Fork294
Fix python implementation marker for setuptools 2.20#227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedMar 2, 2016
Current coverage is |
hoppipolla-critic-bot commentedMar 2, 2016
Critic review:https://critic.hoppipolla.co.uk/r/6233 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please donot make in-place history rewrites (e.g. via |
Bah, Travis failing because of pip dropping 3.2 support. On the upside, easy to fix: we drop 3.2 support. |
@paradoxxxzero Sorry for the delay; can you rebase this on master? |
Done sorry for the delay :) |
landscape-bot commentedMar 23, 2016
Chronial commentedMar 28, 2016
This breaks setup on older setuptools (this is my system setuptools):
|
Otherwise setup.py fail with
error in html5lib setup command: Invalid environment marker: python_implementation == 'CPython'