Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix python implementation marker for setuptools 2.20#227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
gsnedders merged 1 commit intohtml5lib:masterfromparadoxxxzero:master
Mar 24, 2016

Conversation

paradoxxxzero
Copy link
Contributor

Otherwise setup.py fail witherror in html5lib setup command: Invalid environment marker: python_implementation == 'CPython'

Chronial reacted with thumbs up emoji
@codecov-io
Copy link

Current coverage is88.26%

Branch#227 has no coverage reports uploaded yet.

No diff could be generated. No reports formaster found.

Powered byCodecov. Updated on successful CI builds.

@hoppipolla-critic-bot

Critic review:https://critic.hoppipolla.co.uk/r/6233

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please donot make in-place history rewrites (e.g. viagit rebase -i orgit commit --amend) when updating this pull request.

@gsnedders
Copy link
Member

Bah, Travis failing because of pip dropping 3.2 support. On the upside, easy to fix: we drop 3.2 support.

@gsnedders
Copy link
Member

@paradoxxxzero Sorry for the delay; can you rebase this on master?

@paradoxxxzero
Copy link
ContributorAuthor

Done sorry for the delay :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling5dac3ac on paradoxxxzero:master into4205423 on html5lib:master.

@gsneddersgsnedders merged commitd999875 intohtml5lib:masterMar 24, 2016
@Chronial
Copy link

This breaks setup on older setuptools (this is my system setuptools):

> python setup.py sdisterror in html5lib setup command: Invalid environment marker: platform_python_implementation == 'CPython'> python --versionPython 2.7.6> easy_install --versionsetuptools 3.3> cat /etc/issueUbuntu 14.04.3 LTS \n \l

@gsnedders
Copy link
Member

@Chronial see#231 for dealing with that; I presume in the future we'll break a relatively small number of setuptools releases.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@paradoxxxzero@codecov-io@hoppipolla-critic-bot@gsnedders@landscape-bot@Chronial

[8]ページ先頭

©2009-2025 Movatter.jp