- Notifications
You must be signed in to change notification settings - Fork302
Lint fixes#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Lint fixes#222
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hoppipolla-critic-bot commentedDec 16, 2015
Critic review:https://critic.hoppipolla.co.uk/r/6056 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please donot make in-place history rewrites (e.g. via |
landscape-bot commentedDec 16, 2015
|
All of these properties should always hold per the API, so assertsseem like a good match here.
Various fixes for the lint filter, and use it to validate treewalker sanity in tests.
This makes the lint filter actually ensure tree walker implementations follow their supposed API, runs all of the tree walker tests through the filter, and fixes a number of bugs it shows up.