- Notifications
You must be signed in to change notification settings - Fork302
Add prospector and fix some bugs#218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes fromall commits
Commits
Show all changes
27 commits Select commitHold shift + click to select a range
c64bfca Get rid of mutable default arguments
gsneddersc1c16ce Avoid noisiness from pylint and the parser's set patterns
gsnedders2c3b64b add pep8/flake8 config to get something useful happening with them
gsnedders8238648 Fix all the files outside of html5lib to flake8 cleanly
gsneddersde6bcf2 Fix incorrectly hidden flake8 errors
gsnedders0bd31c4 Get rid of type()-based type-check
gsneddersd440a83 Silence pytest unused-variable warnings
gsnedders5c1d8e2 Remove duplicate entry from constants.replacementCharacters
gsnedders1b86ccb Remove gratuitious argument in sanitizer
gsnedders82d623b Silence redefined-variable-type
gsneddersa017b88 Silence unused-argument
gsnedderse5d395c Silence wrong-import-position
gsneddersb64df28 Change which way around we overwrite this for clarity's sake
gsneddersdf0b2ba Remove unused import
gsnedders742715d Fix invalid_unicode_re on platforms supporting lone surrogates
gsnedderscd74ec7 Fix comment
gsnedders15e126f Silence eval-used
gsneddersbfc278a Silence bare-except
gsneddersb46fcdf Silence too-many-nested-blocks
gsnedders6945bc4 Silence not-callable
gsnedders0c290e0 Kill long-dead finalText code
gsneddersda099dc Silence a buggily output non-parent-init-called
gsnedders97427de Fix indentation
gsnedders2afe09b Make this in practice unreachable code work on Py2
gsneddersc0df867 Silence arguments-differ
gsnedders5dce4f2 Silence protected-access
gsneddersa2b8c11 Add prospector/pylint config for the sake of Landscape.
gsneddersFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
21 changes: 21 additions & 0 deletions.prospector.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| strictness: veryhigh | ||
| doc-warnings: false | ||
| test-warnings: false | ||
| max-line-length: 139 | ||
| requirements: | ||
| - requirements.txt | ||
| - requirements-test.txt | ||
| - requirements-optional.txt | ||
| ignore-paths: | ||
| - parse.py | ||
| - utils/ | ||
| python-targets: | ||
| - 2 | ||
| - 3 | ||
| mccabe: | ||
| run: false |
10 changes: 10 additions & 0 deletions.pylintrc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| [MASTER] | ||
| ignore=tests | ||
| [MESSAGES CONTROL] | ||
| # messages up to fixme should probably be fixed somehow | ||
| disable = redefined-builtin,attribute-defined-outside-init,anomalous-backslash-in-string,no-self-use,redefined-outer-name,bad-continuation,wrong-import-order,superfluous-parens,no-member,duplicate-code,super-init-not-called,abstract-method,property-on-old-class,wrong-import-position,no-name-in-module,no-init,bad-mcs-classmethod-argument,bad-classmethod-argument,fixme,invalid-name,import-error,too-few-public-methods,too-many-ancestors,too-many-arguments,too-many-boolean-expressions,too-many-branches,too-many-instance-attributes,too-many-locals,too-many-lines,too-many-public-methods,too-many-return-statements,too-many-statements,missing-docstring,line-too-long,locally-disabled,locally-enabled,bad-builtin,deprecated-lambda | ||
| [FORMAT] | ||
| max-line-length=139 | ||
| single-line-if-stmt=no |
7 changes: 2 additions & 5 deletionsflake8-run.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -5,8 +5,5 @@ if [[ ! -x $(which flake8) ]]; then | ||
| exit 1 | ||
| fi | ||
| flake8 `dirname $0` | ||
| exit $? | ||
1 change: 0 additions & 1 deletionhtml5lib/constants.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -2819,7 +2819,6 @@ | ||
| 0x0d: "\u000D", | ||
| 0x80: "\u20AC", | ||
| 0x81: "\u0081", | ||
| 0x82: "\u201A", | ||
| 0x83: "\u0192", | ||
| 0x84: "\u201E", | ||
11 changes: 6 additions & 5 deletionshtml5lib/filters/sanitizer.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
16 changes: 11 additions & 5 deletionshtml5lib/html5parser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
10 changes: 5 additions & 5 deletionshtml5lib/ihatexml.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.