- Notifications
You must be signed in to change notification settings - Fork302
Add a more general fix for #127 (CPy #20007) based on #136.#186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hoppipolla-critic-bot commentedApr 26, 2015
Critic review:https://critic.hoppipolla.co.uk/r/4800 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please donot make in-place history rewrites (e.g. via |
gsnedders commentedApr 28, 2015
@SimonSapin this may be of interest to you (maybe) |
SimonSapin commentedApr 28, 2015
According toKozea/WeasyPrint@e14653c , html5lib 0.999 already had a work around that was enough for WeasyPrint. Probably18bc278. |
SimonSapin commentedApr 28, 2015
Oh, looking closer, this is a similar but different work around. I don’t remember WeasyPrint being affected by that one, though. |
gsnedders commentedApr 28, 2015
Yeah, from memory you for were just trying to get it to be more complete, rather than needing it yourself. I think? |
SimonSapin commentedApr 28, 2015
Maybe. But to be honest I’ve kind of moved on from Python :) |
c4d1655 to3b3bc21Comparelandscape-bot commentedDec 12, 2015
3b3bc21 tobf7da77Compare
This gets stuff working with
urllib.response.addurlinfo. See#127 and#136.