Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

setup.py: Require ordereddict for Python 2.6#177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

msabramo
Copy link
Contributor

Without this, a client who uses the alphabetical attribute sorting feature ofHTMLSerializer on Python 2.6 will get:

File"/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/serializer/htmlserializer.py",line309,inrenderreturn"".join(list(self.serialize(treewalker)))File"/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/serializer/htmlserializer.py",line196,inserializefrom ..filters.alphabeticalattributesimportFilterFile"/Users/marca/dev/git-repos/bleach/.tox/py26/lib/python2.6/site-packages/html5lib/filters/alphabeticalattributes.py",line8,in<module>fromordereddictimportOrderedDictImportError:Nomodulenamedordereddict

@hoppipolla-critic-bot

Critic review:https://critic.hoppipolla.co.uk/r/3483

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please donot make in-place history rewrites (e.g. viagit rebase -i orgit commit --amend) when updating this pull request.

msabramo added a commit to msabramo/bleach that referenced this pull requestDec 12, 2014
because html5lib needs it for alpha-sorted attributes when on Python 2.6and it doesn't specify it as a dependency (seehtml5lib/html5lib-python#177)
msabramo added a commit to msabramo/bleach that referenced this pull requestDec 12, 2014
because html5lib needs it for alpha-sorted attributes when on Python 2.6and it doesn't specify it as a dependency (seehtml5lib/html5lib-python#177)
jgraham added a commit that referenced this pull requestDec 12, 2014
@jgrahamjgraham merged commit3b3c103 intohtml5lib:masterDec 12, 2014
@gsnedders
Copy link
Member

This really shouldn't have been r+'d/merged… This needs a changelog entry, the readme needs to be updated so it's accurate, and the requirements*.txt files need updating.

gsnedders added a commit that referenced this pull requestApr 29, 2015
…_py26"This reverts commit3b3c103, reversingchanges made to7cce65b.Revert this till#179 is sorted.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@msabramo@hoppipolla-critic-bot@gsnedders@jgraham
[8]ページ先頭
©2009-2025 Movatter.jp