- Notifications
You must be signed in to change notification settings - Fork294
Add expected failures#174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
hoppipolla-critic-bot commentedNov 24, 2014
Critic review:https://critic.hoppipolla.co.uk/r/3259 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please donot make in-place history rewrites (e.g. via |
We can't currently add the lone-surrogates tests because theexpected failures file is UTF-8 and we can't have lone-surrogatesthere. Le sigh…
abbe5b8 toe706397CompareAlso update the expected failures now we no longer fail a test.
We should probably include the whole test in the XFAIL file, and include some code to practically update expectations. |
This is basically abandoned in lieu of the expected_failures_pytest branch in my repo, given that provides a far better basis to be able to programmatically update expectations. |
This isn't quite finished: notably, we still have four failures in the tokeniser tests because we can't currently add the lone-surrogates tests because the expected failures file is UTF-8 and we can't have lone-surrogates there. Options are to have a WTF-8 codec or add some escapes to test data files (optionally just for new files, maybe?) or to just fix the tokeniser and worry about this later, I think. Suggestions?