Use python sets#158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

blag wants to merge1 commit intohtml5lib:masterfromblag:use_python_sets

Closed

Use python sets#158

blag wants to merge1 commit intohtml5lib:masterfromblag:use_python_sets

Conversation

Copy link

blag commentedMay 22, 2014

Instead of

for (loop):    if (condition):        continue

simply use Python sets:

for attr in set(attrs.keys()).intersection(set(self.attr_val_is_uri)):    ...

Copy link

hoppipolla-critic-bot commentedMay 22, 2014

Critic review:https://critic.hoppipolla.co.uk/r/1615

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please donot make in-place history rewrites (e.g. viagit rebase -i orgit commit --amend) when updating this pull request.

Copy link

Member

gsnedders commentedMay 29, 2014

Can you have each branch based on upstream master, so you don't have massive overlap between PRs? Note that#110 makes large changes to the sanitizer — including changing the lists to sets.