- Notifications
You must be signed in to change notification settings - Fork302
Allow data URI schemes, with content type whitelist#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Fromhttps://en.wikipedia.org/wiki/Data_URI_scheme, allow the psuedo-protocol 'data'.
…tests to correctly check URIs
Conflicts:html5lib/sanitizer.py
hoppipolla-critic-bot commentedMay 22, 2014
Critic review:https://critic.hoppipolla.co.uk/r/1612 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please donot make in-place history rewrites (e.g. via |
jgraham commentedAug 13, 2014
There are comments in the critic review, in case that wasn't obvious. |
… to non-capturing subpatterns
gsnedders commentedApr 28, 2015
Rebased intof644865. Thanks! Sorry for leaving the review for so long! |
blag commentedApr 29, 2015
No problem, glad to see it made it in! :) |
Also, use proper URIs in the tests.
Note that the content type whitelist currently only contains 'image/png'; this can be filled out in a separate PR after a more complete discussion about allowable content types.