Critic review:https://critic.hoppipolla.co.uk/r/521

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please donot make in-place history rewrites (e.g. viagit rebase -i orgit commit --amend) when updating this pull request.

Note that thee.name attribute ofwebencodingd.Encoding objects is the name inhttp://encoding.spec.whatwg.org/.

Not all such names are recognized in Python.e.codec_info.name is, except for the x-user-defined encoding that does not exist in Python and webencoding defines. To fix that, use eg.e.codec_info.streamreader instead ofcodecs.getreader(). (Not that x-user-defined is very useful anyway…)

Still,documentEncoding (#123) should be the spec name, or even the Encoding object.

Note withouthtml5lib/html5lib-tests#40 this fails a fair number of tests.

Repository health decreased by 0.54% when pulling2abaeae on gsnedders:webencodings into46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

Build seems to be passing with XPASSes, hmm.

Repository health decreased by 0.54% when pullingd659cf3 on gsnedders:webencodings into46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

Repository health decreased by 0.54% when pullingff8bbf8 on gsnedders:webencodings into46dae3d on html5lib:master.

• 2 new problems were found (including 1 error and 1 code smell).
• 5 problems were fixed (including 1 error and 4 code smells).

@jgraham r?