Also fix #127 with addinfourl#134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

SimonSapin wants to merge1 commit intohtml5lib:masterfromSimonSapin:python-bug20007

Closed

Also fix #127 with addinfourl#134

SimonSapin wants to merge1 commit intohtml5lib:masterfromSimonSapin:python-bug20007

Conversation

Copy link

Contributor

SimonSapin commentedDec 27, 2013

Reported on IRC by@mattaustin:http://krijnhoetmer.nl/irc-logs/whatwg/20131227#l-188

Alsofixhtml5lib#127with addinfourl

1544aca

Copy link

hoppipolla-critic-bot commentedDec 27, 2013

Critic review:https://critic.hoppipolla.co.uk/r/490

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please donot make in-place history rewrites (e.g. viagit rebase -i orgit commit --amend) when updating this pull request.

Copy link

mattaustin commentedDec 27, 2013

I tested this in my app which used FancyURLOpener().open(), and returned a urllib.response.addinfourl instance. using Python 3.3 (Python 2.7 and 3.2 were unaffected), before the patch, the parser returned an empty html document. Afterwards it returned the expected content. Thanks@SimonSapin

Copy link

Member

gsnedders commentedDec 27, 2013

As I said on IRC to@SimonSapin: Can we change this to just pass afirstChunk intoHTMLUnicodeInputStream andHTMLBinaryInputStream, so we can work around all 20007 issues all at one? It's ugly, but it stops endless isinstance checks for this.