Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add a usedEncoding method to HTML5Parser, fix #121#123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
SimonSapin wants to merge2 commits intohtml5lib:masterfromSimonSapin:used-encoding

Conversation

@SimonSapin
Copy link
Contributor

This turned out to be easy enough to add.

I don’t really like theusedEncoding name, but I don’t have a better idea. Feel free to suggest something else.

@hoppipolla-critic-bot

Critic review:https://critic.hoppipolla.co.uk/r/445

This is an external review system which you may optionally use for the code review of your pull request.

@gsnedders
Copy link
Member

Do we actually want this to be a method and not just an attribute?

@SimonSapin
Copy link
ContributorAuthor

On the parser it could be a property rather than a method. I can update the PR if you prefer that, I don’t have a strong opinion.

@SimonSapin
Copy link
ContributorAuthor

One changed line was missing in the last commit, which I just updated. Force-pushing an amended commit has apparently upset Critic…

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SimonSapin@hoppipolla-critic-bot@gsnedders
[8]ページ先頭
©2009-2025 Movatter.jp