Commite4f6fa1

committed

Fix tokenizer test harness to not decode tests multiple times.

Given a double escaped test, if it had multiple initial states, thesame test object would be decoded multiple times: this led to bogusresults on every run except the first.

1 parenta0415f2 commite4f6fa1Copy full SHA for e4f6fa1

File tree

1 file changed

-6

lines changed

html5lib/tests
- test_tokenizer.py

1 file changed

-6

lines changed

`‎html5lib/tests/test_tokenizer.py`

Lines changed: 2 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -144,10 +144,6 @@ def decode(inp):`
`144`	`144`	`defrunTokenizerTest(test):`
`145`	`145`	`warnings.resetwarnings()`
`146`	`146`	`warnings.simplefilter("error")`
`147`		`-#XXX - move this out into the setup function`
`148`		`-#concatenate all consecutive character tokens into a single token`
`149`		`-if'doubleEscaped'intest:`
`150`		`-test=unescape(test)`
`151`	`147`
`152`	`148`	`expected=concatenateCharacterTokens(test['output'])`
`153`	`149`	`if'lastStartTag'notintest:`
`@@ -183,10 +179,10 @@ def testTokenizer():`
`183`	`179`	`testName=os.path.basename(filename).replace(".test","")`
`184`	`180`	`if'tests'intests:`
`185`	`181`	`forindex,testinenumerate(tests['tests']):`
`186`		`-#Skip tests with a self closing flag`
`187`		`-skip=False`
`188`	`182`	`if'initialStates'notintest:`
`189`	`183`	`test["initialStates"]= ["Data state"]`
	`184`	`+if'doubleEscaped'intest:`
	`185`	`+test=unescape(test)`
`190`	`186`	`forinitialStateintest["initialStates"]:`
`191`	`187`	`test["initialState"]=capitalize(initialState)`
`192`	`188`	`yieldrunTokenizerTest,test`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commite4f6fa1

File tree

1 file changed

1 file changed

`‎html5lib/tests/test_tokenizer.py`

0 commit comments