Commit3e50aad

committed

Don't rely on the ElementTree Comment factory being the tag attribute on Comments.

This is needed for xml.etree.cElementTree under 2.6 (and likely hence custominstalls of cElementTree 1.2), where the tag property is equal toxml.etree.ElementTree.Comment (i.e., the pure Python version).Similarly, don't rely on type(comment.tag), as this is just function!

1 parent4e06f37 commit3e50aadCopy full SHA for 3e50aad

File tree

1 file changed

-2

lines changed

html5lib/treebuilders
- etree.py

1 file changed

-2

lines changed

`‎html5lib/treebuilders/etree.py`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,7 @@`
`13`	`13`
`14`	`14`	`defgetETreeBuilder(ElementTreeImplementation,fullTree=False):`
`15`	`15`	`ElementTree=ElementTreeImplementation`
	`16`	`+ElementTreeCommentType=ElementTree.Comment("asd").tag`
`16`	`17`	`classElement(_base.Node):`
`17`	`18`	`def__init__(self,name,namespace=None):`
`18`	`19`	`self._name=name`
`@@ -207,7 +208,7 @@ def serializeElement(element, indent=0):`
`207`	`208`	`rv.append("\|%s\"%s\""%(' '*(indent+2),element.text))`
`208`	`209`	`ifelement.tail:`
`209`	`210`	`finalText=element.tail`
`210`		`-elifelement.tag==ElementTree.Comment:`
	`211`	`+elifelement.tag==ElementTreeCommentType:`
`211`	`212`	`rv.append("\|%s<!-- %s -->"%(' '*indent,element.text))`
`212`	`213`	`else:`
`213`	`214`	`assertisinstance(element.tag,text_type),"Expected unicode, got %s, %s"%(type(element.tag),element.tag)`
`@@ -275,7 +276,7 @@ def serializeElement(element):`
`275`	`276`	`forchildinelement:`
`276`	`277`	`serializeElement(child)`
`277`	`278`
`278`		`-eliftype(element.tag)==type(ElementTree.Comment):`
	`279`	`+elifelement.tag==ElementTreeCommentType:`
`279`	`280`	`rv.append("<!--%s-->"%(element.text,))`
`280`	`281`	`else:`
`281`	`282`	`#This is assumed to be an ordinary element`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3e50aad

File tree

1 file changed

1 file changed

`‎html5lib/treebuilders/etree.py`

0 commit comments