Commit3953804

alexluong

and

claude

committed

fix: pass basePublisherOpts to GCP Pub/Sub constructor

This resolves the TODO comment and ensures GCP Pub/Sub receivesthe same base publisher configuration as other destination providers.🤖 Generated with [Claude Code](https://claude.com/claude-code)Co-Authored-By: Claude <noreply@anthropic.com>

1 parent880a42e commit3953804Copy full SHA for 3953804

File tree

1 file changed

-2

lines changed

internal/destregistry/providers
- default.go

1 file changed

-2

lines changed

`‎internal/destregistry/providers/default.go‎`

Lines changed: 1 addition & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -102,8 +102,7 @@ func RegisterDefault(registry destregistry.Registry, opts RegisterDefaultDestina`
`102`	`102`	`}`
`103`	`103`	`registry.RegisterProvider("aws_s3",awsS3)`
`104`	`104`
`105`		`-// TODO: should basePublisherOpts be passed here?`
`106`		`-gcpPubSub,err:=destgcppubsub.New(loader)`
	`105`	`+gcpPubSub,err:=destgcppubsub.New(loader,basePublisherOpts)`
`107`	`106`	`iferr!=nil {`
`108`	`107`	`returnerr`
`109`	`108`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit3953804

File tree

1 file changed

1 file changed

`‎internal/destregistry/providers/default.go‎`

0 commit comments