Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(client): add entity and query functions#93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
crs48 merged 3 commits intomasterfromadd-entity-and-query-to-client
May 6, 2021

Conversation

@crs48
Copy link
Member

@crs48crs48 commentedMay 6, 2021•
edited
Loading

PR Description

PR Checklist

Testing

  • added relevant test coverage
  • no tests needed

Docs

Typescript

  • added or edited relevant Typescript type declarations
  • no type declaration updates needed

Merging

For maintainers.

To merge, select "Squash and Merge". Then:

  1. Make sure the top commit message followsAngular Git Commit Guidelines,
  2. Delete all other commit messages in the description, but keep any lines designatingco-authors so contributors will retain credit for their contributions.

@crs48crs48 added the enhancementNew feature or request labelMay 6, 2021
@crs48crs48 self-assigned thisMay 6, 2021
@vercel
Copy link

vercelbot commentedMay 6, 2021•
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

homebase-example-counter – ./examples/counter

🔍 Inspect:https://vercel.com/homebaseio/homebase-example-counter/Gesp2BBdsYKRm1sacyWPwd8SSQUR
✅ Preview:https://homebase-examp-git-add-entity-and-query-to-client-hom-b6596b.vercel.app

homebase-example-todo – ./examples/todo

🔍 Inspect:https://vercel.com/homebaseio/homebase-example-todo/2vABcyWaCHYgTH49qMsAWyjR758r
✅ Preview:https://homebase-examp-git-add-entity-and-query-to-client-hom-75d0e3.vercel.app

homebase-example-ts-firebase-todo – ./examples/typescript-firebase-todo

🔍 Inspect:https://vercel.com/homebaseio/homebase-example-ts-firebase-todo/6k4d3uMjstcDjZZrmcJr2fmNNT14
✅ Preview:https://homebase-examp-git-add-entity-and-query-to-client-hom-97656c.vercel.app

homebase-example-roam – ./examples/roam

🔍 Inspect:https://vercel.com/homebaseio/homebase-example-roam/En5aeamToF7Yv7ubRaYMJ9AG9NXi
✅ Preview:https://homebase-examp-git-add-entity-and-query-to-client-hom-99f263.vercel.app

@crs48crs48 linked an issueMay 6, 2021 that may beclosed by this pull request
Copy link
Contributor

@rubinovitzrubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good to me! Cool we could do this with such little code.

One thing: I can't check this since I'm sick and AFC, but does it make sense to update typescript types here?

crs48 reacted with heart emoji
@crs48
Copy link
MemberAuthor

This looks good to me! Cool we could do this with such little code.

One thing: I can't check this since I'm sick and AFC, but does it make sense to update typescript types here?

Yep, just updated them. I noticed them in the checklist. Love that thing!

rubinovitz reacted with laugh emojirubinovitz reacted with hooray emoji

rubinovitz
rubinovitz previously approved these changesMay 6, 2021
Copy link
Contributor

@rubinovitzrubinovitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Beautiful! Thank you!

@crs48crs48 merged commit36f00cc intomasterMay 6, 2021
@crs48crs48 deleted the add-entity-and-query-to-client branchMay 6, 2021 22:38
@github-actions
Copy link

🎉 This PR is included in version 0.6.0 🎉

The release is available on:

Yoursemantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@groundedsagegroundedsageAwaiting requested review from groundedsage

1 more reviewer

@rubinovitzrubinovitzrubinovitz approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crs48crs48

Labels

enhancementNew feature or requestreleased

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Request for documentation of usage without react

3 participants

@crs48@rubinovitz
[8]ページ先頭
©2009-2025 Movatter.jp