- Notifications
You must be signed in to change notification settings - Fork52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
3 Feb 2025 patches (Lint fixes)#1211
Open
alexpreynolds wants to merge3 commits intohiglass:developChoose a base branch fromalexpreynolds:apr-PR-develop-v1p13p5-postLintFixes
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
3 Feb 2025 patches (Lint fixes)#1211
alexpreynolds wants to merge3 commits intohiglass:developfromalexpreynolds:apr-PR-develop-v1p13p5-postLintFixes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ss#1210)* 20 Nov 2024 patches (PNG/SVG export fixes, memory leak fixes, tooltip improvements, other fixes)* 20 Nov 2024 patches (tooltip improvements, distribution)* 22 Nov 2024 patches (HorizontalTiled1DPixiTrack constIndicator null check)* 22 Nov 2024 patches (change renderer options to fix deprecated property error)* 26 Nov 2024 patches (exception handling for stopHover call)* 28 Jan 2025 patches (Clean v1.13.4 commit history with enzyme, typecheck and SCSS fixes)* 28 Jan 2025 patches (Remove commented code)* 28 Jan 2025 patches (Remove package-lock)* 28 Jan 2025 patches (Fix biome format error)* 3 Feb 2025 patches (Resolve reviewed changes inhiglass#1210)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I am following up on a previous push of commits that were merged early. There remain some small linting and CI test fixes that I need to address.
Fixes #___
Checklist