By submitting this pull request, I confirm that my contribution is made under the terms of theApache 2.0 license
and can be relicensed under the terms of theLGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please checkhere.

https://hibernate.atlassian.net/browse/HHH-19879

Copy link

hibernate-github-botbot commentedOct 15, 2025•
edited
Loading

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

github-advanced-securitybot found potential problems

Oct 15, 2025

View reviewed changes

Copy link

github-advanced-securitybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check theFiles changed tab for more details.

koentsje force-pushed themerge-tools-into-orm branch 2 times, most recently from9d4e4ec to094c21aCompare

October 20, 2025 14:10

yrodiere reviewed

Oct 21, 2025

View reviewed changes

Copy link

Member

yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I added a few comments below to track things we discussed and that we shouldn't forget.

Also created a Jira issue:https://hibernate.atlassian.net/browse/HHH-19879

tooling/hibernate-gradle-plugin/src/main/java/org/hibernate/tool/gradle/Plugin.java Outdated

		import org.hibernate.tool.gradle.task.GenerateJavaTask;
		import org.hibernate.tool.gradle.task.RunSqlTask;

		public class Plugin implements org.gradle.api.Plugin<Project> {

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should probably be the same plugin as enhancement, so that we can use a syntax like this one:

hibernate {    enhancement { ... }    reveng { ... }}

tooling/hibernate-reveng/hibernate-reveng.gradle

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Honest question: would this make sense to use in an application/framework as a library, and if so do we want to keep this module undertooling/?

.../src/test/java/org/hibernate/tool/reveng/api/core/ReverseEngineeringStrategyFactoryTest.java

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Todo: migrate (all?) other tests from Tools. We can target h2 only for a start.

Main challenge would be conveting hbm.xml to orm.xml (mapping.xml?) or annotations.

tooling/hibernate-maven-plugin/src/main/java/org/hibernate/tool/maven/TransformHbmMojo.java Outdated

Comment on lines 38 to 42

		@Mojo(
		name = "hbm2orm",
		defaultPhase = GENERATE_RESOURCES,
		requiresDependencyResolution = ResolutionScope.RUNTIME)
		public class TransformHbmMojo extends AbstractMojo {

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is great and I know people have been asking for it.

We need it documented, though :)

tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/hbm2ddl/SchemaExport.java Outdated

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There is something wrong here. Seem you duplicated the package? TheSchemaExport class already exists in this module.

tooling/hibernate-reveng/src/main/java/org/hibernate/tool/hbm2ddl/SchemaExport.java Outdated

Copy link

Member

yrodiereOct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As discussed, the classes you duplicated here should instead be moved fromhibernate-ant to this module.

koentsje force-pushed themerge-tools-into-orm branch 25 times, most recently from8239046 to30152daCompare

October 24, 2025 09:00

koentsje force-pushed themerge-tools-into-orm branch fromd906480 toc35239fCompare

October 28, 2025 17:23

github-advanced-securitybot found potential problems

Oct 28, 2025

View reviewed changes

...ate-reveng/src/main/java/org/hibernate/tool/reveng/internal/export/java/EntityPOJOClass.java FixedShow fixedHide fixed

koentsje force-pushed themerge-tools-into-orm branch 7 times, most recently from6080986 to1dfd0deCompare

November 3, 2025 19:49

github-advanced-securitybot found potential problems

Nov 3, 2025

View reviewed changes

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/ConfigurationTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/HibernateToolTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/JDBCConfigurationTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/JPAConfigurationTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/JavaFormatterTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/hbm2ddl/SchemaUpdateTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/hbm2ddl/SchemaExportTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/hbm2ddl/hbm2ddl/SchemaExport.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/ExporterTask.java FixedShow fixedHide fixed

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/ConfigurationTask.java FixedShow fixedHide fixed

koentsje force-pushed themerge-tools-into-orm branch 2 times, most recently froma0eb131 to0c719d0Compare

November 4, 2025 08:10

github-advanced-securitybot found potential problems

Nov 4, 2025

View reviewed changes

tooling/hibernate-ant/src/main/java/org/hibernate/tool/ant/ConfigurationTask.java FixedShow fixedHide fixed

koentsje force-pushed themerge-tools-into-orm branch 11 times, most recently from8c982e8 to1659453Compare

November 5, 2025 09:43

github-advanced-securitybot found potential problems

Nov 5, 2025

View reviewed changes

tooling/hibernate-maven-plugin/src/main/java/org/hibernate/tool/maven/TransformHbmMojo.java FixedShow fixedHide fixed

koentsje force-pushed themerge-tools-into-orm branch 2 times, most recently from1659453 to8621badCompare

November 6, 2025 10:42

github-advanced-securitybot found potential problems

Nov 6, 2025

View reviewed changes

...nate-reveng/src/main/java/org/hibernate/tool/reveng/internal/core/reader/IndexProcessor.java FixedShow fixedHide fixed

HHH-19879: Move Hibernate Tools' reveng module to Hibernate ORM and …

b61a115

…merge the relevant ant/gradle/maven plugins   - Add the Reverse Engineering moduleSigned-off-by: Koen Aers <koen.aers@gmail.com>

koentsje force-pushed themerge-tools-into-orm branch from8621bad tob61a115Compare

November 6, 2025 12:09

Labels

None yet

Movatterモバイル変換

Uh oh!

DRAFT: Merge tools into orm#11123

Are you sure you want to change the base?

DRAFT: Merge tools into orm#11123

Conversation

koentsje commentedOct 15, 2025• edited by hibernate-github-botbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

hibernate-github-botbot commentedOct 15, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

github-advanced-securitybot left a comment

Choose a reason for hiding this comment

Uh oh!

yrodiere left a comment

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

yrodiereOct 21, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

koentsje commentedOct 15, 2025•
edited by hibernate-github-botbot
Loading

hibernate-github-botbot commentedOct 15, 2025•
edited
Loading