- Notifications
You must be signed in to change notification settings - Fork300
feat: add .pre-commit-hooks.yaml#618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Motivation:I would like to use helm-unittest in a pre-commit hook.Modification:Add a docker_image based pre-commit hook (via .pre-commit-hooks.yaml)
| - id: helm-unittest | ||
| name: helm-unittest | ||
| language: docker_image | ||
| entry: helmunittest/helm-unittest:3.17.1-0.8.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is there a build script / process that automatically updates version references? If not, then the docker image tag here will need to be manually updated whenever a new version is released.
ivankatliarchuk commentedMar 27, 2025
I'm unsure, it looks like it required docker. As docker a proprietary software aka not an open source, it has licence restrictions if you work for enterprises. Is it possible or safe to assume that helm unit test installed as binary or as helm plugin? Would be nice to have more options than just docker basically |
janeklb commentedMar 27, 2025
We could provide both options so that users could select which one they want to use (depending on their environment / what they have available). FWIW instead of using docker you can use podman (open source) and it should work just finepre-commit/pre-commit#2173 |
janeklb commentedMar 28, 2025
@ivankatliarchuk is there anything I can do in order to get this to a state you'd be happy to merge? |
ivankatliarchuk commentedMar 28, 2025
Lgtm. I have no approval rights sorry. |
guhcampos commentedSep 24, 2025
This is good stuff. |
Uh oh!
There was an error while loading.Please reload this page.
Motivation
I would like to use helm-unittest in a pre-commit hook.
Modification
Add a
language: docker_imagepre-commit hookNote
This is
similar tobuilding on top of#253; this also adds a hook that useslanguage: docker_imagewhich allows you to run the hook in environments wherehelmor this plugin (helm unittest) are unavailable - eg. CI.