Commitb79f5de

committed

fix(certs): limit=0 is invalid in DRF 3.4

1 parent4db0fe3 commitb79f5deCopy full SHA for b79f5de

File tree

-4

lines changed

-4

lines changed

Lines changed: 7 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -180,14 +180,17 @@ var _ = Describe("deis certs", func() {`
`180`	`180`	`Specify("that user can limit the number of certs returned by certs:list",func() {`
`181`	`181`	randCertRegExp:=`\d{0,9}-cert`
`182`	`182`
`183`		`-sess,err:=cmd.Start("deis certs:list -l 0",&user)`
`184`		`-Eventually(sess).Should(Say("No certs"))`
	`183`	`+sess,err=cmd.Start("deis certs:list --limit=1",&user)`
	`184`	`+Eventually(sess).Should(Say(randCertRegExp))`
	`185`	`+Eventually(sess).Should(Not(Say(randCertRegExp)))`
`185`	`186`	`Expect(err).NotTo(HaveOccurred())`
`186`	`187`	`Eventually(sess).Should(Exit(0))`
`187`	`188`
`188`		`-sess,err=cmd.Start("deis certs:list --limit=1",&user)`
	`189`	`+// limit=0 is invalid as of DRF 3.4`
	`190`	`+// https://github.com/tomchristie/django-rest-framework/pull/4194`
	`191`	`+sess,err=cmd.Start("deis certs:list --limit=0",&user)`
	`192`	`+Eventually(sess).Should(Say(randCertRegExp))`
`189`	`193`	`Eventually(sess).Should(Say(randCertRegExp))`
`190`		`-Eventually(sess).Should(Not(Say(randCertRegExp)))`
`191`	`194`	`Expect(err).NotTo(HaveOccurred())`
`192`	`195`	`Eventually(sess).Should(Exit(0))`
`193`	`196`

Comments

(0)