Reviewing files that changed from the base of the PR and betweenf2adb33 and3fbcd31.

• src/jmcomic/jm_config.py (1 hunks)
• src/jmcomic/jm_option.py (5 hunks)
• src/jmcomic/jm_toolkit.py (1 hunks)

src/jmcomic/jm_option.py (3)

64-74:LGTM with minor style note.

Thenormalize_zh parameter is well-documented and properly stored. The default value'zh-cn' aligns with the configuration injm_config.py.

Note: Static analysis flagged the full-width comma (，) in the docstring at line 68. This is acceptable for Chinese documentation, though you may want to standardize on half-width punctuation for consistency with Python conventions.

---

217-229:LGTM!

Thecopy_option method correctly propagates thenormalize_zh setting when creating a copy of the option.

---

341-353:LGTM!

Thedeconstruct method correctly includesnormalize_zh to ensure the setting is persisted when saving options to a file.

src/jmcomic/jm_toolkit.py (2)

330-333:LGTM!

Good refactoring to delegate to the new genericto_zh method while preserving the existingto_zh_cn API for backward compatibility.

---

335-359: Based on my verification, I found that:

1. zhconv dependency status: zhconv is inrequirements-dev.txt (development-only) and is NOT in the maininstall_requires ordependencies sections of setup.py/pyproject.toml. This is intentional design—zhconv is already treated as an optional dependency.

2. Exception handling appropriateness: For an optional dependency, the broadexcept Exception with silent fallback to the original string is a reasonable and safe pattern. The method correctly handles both missing library and conversion errors by returning the original string.

3. jm_log existence: The function exists and is used throughout the codebase for logging, confirming the suggested improvement is feasible.

The implementation already follows good defensive patterns for optional dependencies. The current code safely handles the case when zhconv is unavailable.

---

No actionable issues found—current implementation appropriately handles zhconv as optional.

Theto_zh method correctly manages zhconv as an optional dependency. While zhconv is listed inrequirements-dev.txt, it's appropriately excluded from the main dependency list in setup.py/pyproject.toml, meaning users who don't need Chinese text conversion normalization won't be forced to install it. The defensive exception handling with silent fallback is acceptable for this optional feature—users get the original string if the library isn't available or conversion fails.

The implementation is sound. No changes are required.

src/jmcomic/jm_config.py (1)

414-414:Verify backward compatibility claim - inconclusive without git history.

The PR claims "default behavior remains unchanged," but verification is inconclusive:

• DirRule.__init__ has parameter defaultnormalize_zh='zh-cn' (line 64, jm_option.py)
• Code defensively checksif normalize_zh is None to apply "no conversion" (lines 100-102)
• Line 414 now explicitly sets'normalize_zh': 'zh-cn' inDEFAULT_OPTION_DICT
• No git history, tests, or changelog available to confirm previous state

The key question: Wasnormalize_zh previouslyabsent fromDEFAULT_OPTION_DICT (relying on parameter default 'zh-cn'), or was it explicitly set toNone/'none' (enabling no conversion by default)?

Manually verify the previous version of this configuration dictionary to confirm whether this change affects existing behavior.

Reviewing files that changed from the base of the PR and between3fbcd31 and012a8cf.

• assets/option/option_test_api.yml (1 hunks)
• src/jmcomic/jm_config.py (1 hunks)
• src/jmcomic/jm_option.py (5 hunks)
• src/jmcomic/jm_toolkit.py (1 hunks)

• src/jmcomic/jm_config.py

assets/option/option_test_api.yml (1)

4-4:LGTM!

The configuration addition correctly enables Simplified Chinese normalization for directory names, aligning with the PR's objective to prevent duplicate directories caused by Chinese variant differences.

src/jmcomic/jm_option.py (4)

2-2:LGTM!

The import ofJmcomicText is necessary for the Chinese normalization functionality added in this PR.

---

98-100:LGTM!

The normalization logic is correctly placed after rule parsing but before Windows path normalization. The implementation properly:

• Skips base directory paths
• Converts to string before normalization
• Falls back gracefully if zhconv is unavailable or normalization fails

---

213-213:LGTM!

The defensive use ofgetattr with a default value ensures backward compatibility with existingDirRule instances that may not have thenormalize_zh attribute.

---

339-339:LGTM!

The propagation indeconstruct mirrors the approach incopy_option, ensuring the configuration is properly serialized. The defensivegetattr maintains backward compatibility.

src/jmcomic/jm_toolkit.py (1)

335-356:LGTM! Robust error handling with appropriate fallback behavior.

The implementation correctly:

• Handles None inputs gracefully
• Uses zhconv for conversion when available
• Falls back to the original string on any error (missing library, invalid target, conversion failure)
• Logs errors for debugging without breaking functionality

This defensive approach aligns with the PR's goal of avoiding disruption when normalization cannot be performed.

The broadException catch is appropriate here despite the static analysis warning, as it ensures graceful degradation when zhconv is unavailable or encounters unexpected issues.

Based on static analysis.

Reviewing files that changed from the base of the PR and between012a8cf andbf42f56.

• src/jmcomic/jm_config.py (1 hunks)
• src/jmcomic/jm_option.py (5 hunks)
• src/jmcomic/jm_toolkit.py (1 hunks)

• src/jmcomic/jm_config.py

src/jmcomic/jm_toolkit.py (1)

331-333:LGTM: Clean refactoring to delegate to the new generic method.

The refactoring ofto_zh_cn to delegate toto_zh(s, 'zh-cn') is correct and maintains backward compatibility while reducing code duplication.

src/jmcomic/jm_option.py (4)

2-2:LGTM: Import added for Chinese normalization support.

The import ofJmcomicText is correctly added to support the new Chinese normalization functionality.

---

98-100:LGTM: Chinese normalization correctly applied before Windows path sanitization.

The Chinese normalization is applied at the right point in the flow:

1. After parsing the rule to get the path component
2. Before Windows path name sanitization
3. Only for non-base-dir paths

This ensures consistent directory naming regardless of simplified/traditional Chinese variants in the source data.

---

208-220:LGTM: normalize_zh properly propagated in copy_option.

Thenormalize_zh field is correctly included when creating a copy of the option, ensuring the configuration is preserved.

---

332-344:LGTM: normalize_zh included in option serialization.

Thenormalize_zh field is correctly included in thedeconstruct method, ensuring it's properly serialized when saving the option to a file.

Reviewing files that changed from the base of the PR and betweenbf42f56 and8755330.

• src/jmcomic/__init__.py (1 hunks)
• src/jmcomic/jm_config.py (1 hunks)
• src/jmcomic/jm_toolkit.py (2 hunks)

src/jmcomic/jm_config.py (1)

414-414:LGTM! Configuration addition is clean.

Thenormalize_zh: None addition todir_rule maintains backward compatibility by defaulting to off. This aligns with the PR objective to provide optional Chinese text normalization without changing existing behavior.

src/jmcomic/__init__.py (1)

5-5:Version bump looks good.

Standard version increment to reflect the newnormalize_zh feature.

src/jmcomic/jm_toolkit.py (1)

331-333:Good backward compatibility approach.

Theto_zh_cn wrapper correctly delegates to the newto_zh method, maintaining compatibility with existing callers.