- Notifications
You must be signed in to change notification settings - Fork1.7k
DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092
DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092gptlang wants to merge 2 commits intohcengineering:developfrom
Conversation
lexiv0re commentedNov 4, 2024
Hello@gptlang , thanks for your contribution! |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
aonnikov commentedNov 8, 2024
Just an idea, can we use SES url to determine if we should use OTP login method? If we don't have email service configured, then we should not have SES url and OTP is not possible. |
lexiv0re commentedNov 8, 2024
@aonnikov yeah, that's a good idea. I thought about this too and it appears we don't currently have SES url in our front service config file. So we'd have to add SES_URL to the front only to check whether OTP is supported or not. Why I probably would't want to expose it right now is that with the upcoming changes in the account we may immediately have other OTP delivery methods connected to various social logins other than email (e.g. telegram) so it might become a little bit tricky then. |
Signed-off-by: Antonio Cheong <acheong@duti.dev>
Signed-off-by: Antonio Cheong <acheong@duti.dev>
When self hosting, SMTP isn't supported yet. The default email based login doesn't work. Login by email is just a click away but it would be easier if that could just be made default.
This change makes it such that we can simply add
to the environment to switch the defaults around.