Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092

Open
gptlang wants to merge 2 commits intohcengineering:developfrom
gptlang:develop
Open

DEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)#7092
gptlang wants to merge 2 commits intohcengineering:developfrom
gptlang:develop

Conversation

@gptlang
Copy link

When self hosting, SMTP isn't supported yet. The default email based login doesn't work. Login by email is just a click away but it would be easier if that could just be made default.

This change makes it such that we can simply add

LOGIN_PASSWORD_ONLY=true

to the environment to switch the defaults around.

@gptlanggptlang marked this pull request as ready for reviewNovember 3, 2024 04:15
@haiodohaiodo requested a review fromlexiv0reNovember 4, 2024 04:53
@lexiv0re
Copy link
Collaborator

Hello@gptlang , thanks for your contribution!

@aonnikov
Copy link
Member

Just an idea, can we use SES url to determine if we should use OTP login method? If we don't have email service configured, then we should not have SES url and OTP is not possible.

@lexiv0re
Copy link
Collaborator

@aonnikov yeah, that's a good idea. I thought about this too and it appears we don't currently have SES url in our front service config file. So we'd have to add SES_URL to the front only to check whether OTP is supported or not. Why I probably would't want to expose it right now is that with the upcoming changes in the account we may immediately have other OTP delivery methods connected to various social logins other than email (e.g. telegram) so it might become a little bit tricky then.

@gptlanggptlang marked this pull request as draftNovember 10, 2024 00:29
Signed-off-by: Antonio Cheong <acheong@duti.dev>
Signed-off-by: Antonio Cheong <acheong@duti.dev>
@gptlanggptlang marked this pull request as ready for reviewNovember 10, 2024 00:56
@gptlanggptlang changed the titleLOGIN_PASSWORD_ONLY env variable for self hosting without mailDEFAULT_LOGIN_METHOD env for when mail otp isn't available (self-hosted)Nov 10, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@lexiv0relexiv0relexiv0re requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gptlang@lexiv0re@aonnikov@acheong08

Comments


[8]ページ先頭

©2009-2026 Movatter.jp