Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

make hls speak websocket#4666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
MangoIV wants to merge6 commits intohaskell:master
base:master
Choose a base branch
Loading
fromMangoIV:mangoiv/websocket

Conversation

MangoIV
Copy link
Contributor

@MangoIVMangoIV commentedJul 17, 2025•
edited
Loading

try it out in combination withhttps://github.com/MangoIV/hls-playground by running that withnpm run dev and this withcabal run -f-cabal -f-dynamic exe:haskell-language-server -- -d ws

This is the right thing to do because othewise it is not possible tocreate new ideStates in a single instance of the executable. This willbe useful if the hls executable is supposed to talk to multiple clientsand lives beyond a single client disconnecting.
Previously, when there was no shutdown message by a client and theclient disconnected, resulting in the handlers to be GC'd the race thatwas supposed to free resources for the HieDB & co. would throw a harderror talking about the MVar being unreachable. We would like to insteadfinish gracefully because finishing the race as soon as the MVar wasGC'd is the right thing to do anyway.
@MangoIVMangoIV changed the titleMangoiv/websocketmake hls speak websocketJul 17, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@michaelpjmichaelpjAwaiting requested review from michaelpjmichaelpj will be requested when the pull request is marked ready for reviewmichaelpj is a code owner

@berbermanberbermanAwaiting requested review from berbermanberberman will be requested when the pull request is marked ready for reviewberberman is a code owner

@guibouguibouAwaiting requested review from guibouguibou will be requested when the pull request is marked ready for reviewguibou is a code owner

@0rphee0rpheeAwaiting requested review from 0rphee0rphee will be requested when the pull request is marked ready for review0rphee is a code owner

@soulomoonsoulomoonAwaiting requested review from soulomoonsoulomoon will be requested when the pull request is marked ready for reviewsoulomoon is a code owner

@santiweightsantiweightAwaiting requested review from santiweightsantiweight will be requested when the pull request is marked ready for reviewsantiweight is a code owner

@eddiemundoeddiemundoAwaiting requested review from eddiemundoeddiemundo will be requested when the pull request is marked ready for revieweddiemundo is a code owner

@joyfulmantisjoyfulmantisAwaiting requested review from joyfulmantisjoyfulmantis will be requested when the pull request is marked ready for reviewjoyfulmantis is a code owner

@georgefstgeorgefstAwaiting requested review from georgefstgeorgefst will be requested when the pull request is marked ready for reviewgeorgefst is a code owner

@jvanbrueggejvanbrueggeAwaiting requested review from jvanbrueggejvanbruegge will be requested when the pull request is marked ready for reviewjvanbruegge is a code owner

@July541July541Awaiting requested review from July541July541 will be requested when the pull request is marked ready for reviewJuly541 is a code owner

@ozkutukozkutukAwaiting requested review from ozkutukozkutuk will be requested when the pull request is marked ready for reviewozkutuk is a code owner

@kokobdkokobdAwaiting requested review from kokobdkokobd will be requested when the pull request is marked ready for reviewkokobd is a code owner

@fendorfendorAwaiting requested review from fendorfendor will be requested when the pull request is marked ready for reviewfendor is a code owner

@VeryMilkyJoeVeryMilkyJoeAwaiting requested review from VeryMilkyJoeVeryMilkyJoe will be requested when the pull request is marked ready for reviewVeryMilkyJoe is a code owner

@drsoochdrsoochAwaiting requested review from drsoochdrsooch will be requested when the pull request is marked ready for reviewdrsooch is a code owner

@wz1000wz1000Awaiting requested review from wz1000wz1000 will be requested when the pull request is marked ready for reviewwz1000 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1 participant
@MangoIV
[8]ページ先頭
©2009-2025 Movatter.jp