Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

4416 - show versions of installed packages#4651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
batkot wants to merge10 commits intohaskell:master
base:master
Choose a base branch
Loading
frombatkot:4416-show-package-versions

Conversation

batkot
Copy link
Contributor

Took my chances on implementing@fendor suggestions from@lucalabs-de#4430 MR.

Inlay Hints
Screenshot 2025-07-08 at 23 23 16

CodeLenses got hard to read when there are multiple packages in single line, so I added package name then to make it easier to understand.
Screenshot 2025-07-08 at 23 21 49

As noticed in previous MR, because of limited positioning options lenses can look a bit wonky depending on cabal file formatting. Hover could be a nice (and easy to add) fallback as well, but I'm not sure about status of hover ticket (#4417) and for now I just decided to avoid unnecessary conflicts.

Closes#4416 (based on#4430)

fendor reacted with rocket emoji
@michaelpj
Copy link
Collaborator

Personally I'd be somewhat inclined to do this in a hover rather than an inlay hint, but debatable.

@michaelpj
Copy link
Collaborator

Not sure what a coherent argument would look like, but I would argue something like:

  • Inlay hints are good for things you always want to see that provide missing context
  • Inlay hints are often supposed to be something you can "accept", which adds the content into the buffer. But the inlay hint here isn't valid syntax!
  • Hovers are good for extra information that you want when you are focussing your attention on a specific thing. I think I mostly want to know package versions when I'm thinking about a specific package dependency, so I think that suits hovers a bit more?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@fendorfendorAwaiting requested review from fendorfendor will be requested when the pull request is marked ready for reviewfendor is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show information on installed package versions
2 participants
@batkot@michaelpj

[8]ページ先頭

©2009-2025 Movatter.jp