Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add tests for references to record fields and update symbol retrieval to only include source nodes#4641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

@soulomoon
Copy link
Collaborator

@soulomoonsoulomoon commentedJun 23, 2025•
edited
Loading

Fix#4412
Very small change, ChangegetNamesAtPoint to only include names in the source.

@soulomoonsoulomoon changed the titleAdd tests for references to record fields and update symbol retrievalAdd tests for references to record fields and update symbol retrieval to only include source nodesJun 25, 2025
References to record fields gives too many resultsThis commit adds tests for references to record fields andupdates the symbol retrieval logic to ensure that references to recordfields are handled correctly. The changes is small:- The `getNamesAtPoint` function in `AtPoint.hs` now  only searches for `Name` that are in the source node from `HieAst`.
Copy link
Collaborator

@fendorfendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@soulomoonsoulomoonforce-pushed the4412-textdocumentreferences-on-a-record-field-in-a-definition-returns-way-too-many-things-with-ghc-964 branch from1e912c3 to8277c93CompareJune 25, 2025 14:40
@soulomoonsoulomoon added the merge meLabel to trigger pull request merge labelJun 25, 2025
…eld-in-a-definition-returns-way-too-many-things-with-ghc-964
@mergify
Copy link
Contributor

mergifybot commentedJun 25, 2025

This pull request has been removed from the queue for the following reason:checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a@mergifyio requeue comment.

@soulomoon
Copy link
CollaboratorAuthor

@Mergifyio requeue

mergify[bot] reacted with thumbs up emoji

@mergify
Copy link
Contributor

mergifybot commentedJun 25, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergifymergifybot merged commit5d221b9 intomasterJun 25, 2025
50 of 52 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@fendorfendorfendor approved these changes

@wz1000wz1000Awaiting requested review from wz1000wz1000 is a code owner

Assignees

No one assigned

Labels

merge meLabel to trigger pull request merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

textDocument/references on a record field in a definition returns way too many things with ghc 9.6.4

3 participants

@soulomoon@fendor
[8]ページ先頭
©2009-2025 Movatter.jp