Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork399
replace usages of NormalizedFilePath with NormalizedUri wherever possible#4622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
MangoIV wants to merge5 commits intohaskell:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
oh no already three conflicts 😭 |
5552c2f to26c5db8CompareMangoIV commentedJul 15, 2025
Comment on lines -268 to +275
| --| Runs the action until it ends or until the given MVar is put. | ||
| --| Runs the action until it ends or until the given MVar is put or the thread to fill the mvar is dropped, in which case the MVar will never be filled. | ||
| -- This happens when the thread that handles the shutdown notification dies. Ideally, this should not rely on the RTS detecting the blocked MVar | ||
| -- and instead *also* run the shutdown inf a finally block enclosing the handlers. In which case the BlockedIndefinitelyOnMVar Exception also wouldn't | ||
| -- be thrown. | ||
| -- Rethrows any exceptions. | ||
| untilMVar::MonadUnliftIOm=>MVar()->m()->m() | ||
| untilMVar mvar io= void$ | ||
| waitAnyCancel=<<traverse async [ io , readMVar mvar ] | ||
| untilMVar mvar io= race_ (readMVar mvar`catch`\BlockedIndefinitelyOnMVar->pure()) io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this bit is interesting for a reviewer
This is the right thing to do because othewise it is not possible tocreate new ideStates in a single instance of the executable. This willbe useful if the hls executable is supposed to talk to multiple clientsand lives beyond a single client disconnecting.
Previously, when there was no shutdown message by a client and theclient disconnected, resulting in the handlers to be GC'd the race thatwas supposed to free resources for the HieDB & co. would throw a harderror talking about the MVar being unreachable. We would like to insteadfinish gracefully because finishing the race as soon as the MVar wasGC'd is the right thing to do anyway.
8 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for being to run haskell-language-server against URIs that are not file URIs.
I am not sure about all the places and there's one more change that I will probably have to do to run HLS over websocket.