Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork399
Local binding hints (WIP)#4610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Co-authored-by: fendor <fendor@users.noreply.github.com>
Now let and where clause will show binding type in inlay hints
4c79cba to5eae7caCompare…to local-binding-hints
5eae7ca to9cde704Compareeede0e7 to84673acCompare| properties = emptyProperties | ||
| & defineEnumProperty #mode "Control how type lenses are shown" | ||
| [ (Always, "Always displays type lenses of global bindings") | ||
| , (Exported, "Only display type lenses of exported global bindings") | ||
| , (Diagnostics, "Follows error messages produced by GHC about missing signatures") | ||
| ] Always | ||
| & defineBooleanProperty #localBindingInlayHintOn | ||
| "Display inlay hints of local bindings" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this needs a better explanation for documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this may also be clearer as a three-way enum calledlocalBindingHintsMode with the optionsNoLocalHints,UseInlayHints,UseCodeLenses.
happy to let others bikeshed this, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yeah, sounds good, although I'm somewhat tempted towards a global option for the user preference here.
84673ac toa2759f6Compare| "mode": "always" | ||
| }, | ||
| "globalOn": true | ||
| "inlayHintsOn": true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
regenerate these
I wonder what to do about inlay hints vs code lenses. As I commented in the other issue, I do think we should prefer them if we can. But maybe we need a consistent approach. e.g. something like:
Out of scope for this PR though. |
Give a shout if you need help/want attention on any bit of it in particular! |
will do! haven't had a chance to go through the test failures. |
Uh oh!
There was an error while loading.Please reload this page.
continuation of#4368.
so far, I've merged in changes in master and updated things so they compile with ghc-9.12.
TODO:
update: this now allows either code lenses or inlay hints for local bindings. aswe discussed, I've defaulted this to code lenses, with an optional toggle to flip on inlay hints instead. but the code lenses don't have their tests restored as yet. will reintroduce those tomorrow.