Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork399
Decouple the session loader into reader and writer over the cache#4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
soulomoon wants to merge78 commits intohaskell:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+1,185 −764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
… them to improve performancefixhaskell#4381
…p error loading and cradle files
ba7379b to79a43a0CompareRenames getOptions to getOptionsWorker for clarityRemoves redundant getOptionsLoop functionEnsures session loading is called under the same `Action` context
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (5)
- cabal.project: Language not supported
- ghcide/ghcide.cabal: Language not supported
- ghcide/session-loader/Development/IDE/Session.hs: Language not supported
- ghcide/session-loader/Development/IDE/Session/Diagnostics.hs: Language not supported
- ghcide/session-loader/Development/IDE/Session/OrderedSet.hs: Language not supported
The session initialisation has too many implicit dependencies. To breakthese apart, we extract local functions and turn them into top-leveldefinition with all parameters explicitly given.This commit only makes sure session initialisation functions arepromoted to top-level definitions and tries to simplify them.The top-level definitions are lacking type signatures to make it easierto change them, but we plan to add them back.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Follow up of and already include the changes in#4439
Refactored session loader to use architecture that having multiple readers and writer over the cache .
In bigger project, HLS usually loading up slow. One of the main obstacle is that we are loading ghc options for files in strict sequential order.
I have made an attemp to improve the situation by refactoring this loading into reader and writer over cache. This way, the long laoding file won't be blocking already loaded files, making hls more responsive and smooth.
Also it eliminates session loading for the same file from being multiply requested, by lining up in an ordered set in stead of a list.