- Notifications
You must be signed in to change notification settings - Fork205
Clarify "Building", remove "submodules" in README#1732
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jneira commentedApr 10, 2020 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Hi! The project has not submodules now but it had them for a long time. It is not probable (but possible) that it will need again and Otoh as it is not probable and the instructions are shorter this way, i think we could merge it. |
Installation script executes |
README.md Outdated
| Note, on first invocation of the build script, a GHC is being installed for execution. | ||
| The GHC used for the `install.hs` can be adjusted in `shake.yaml` by using a different resolver. | ||
| Note, on first invocation of the build script, a GHC is installed for execution. If you'd like to use a specific version of GHC for the `install.hs`, you can adjust the resolver in the `install/shake.yaml` file, as this project's build uses the [shake](https://shakebuild.com/) build tool. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
as this project's build uses theshake build tool.
That is not really the reason why that works, it works because it is a regular haskell project that just happens to use shake.
I had some confusion when following the install/build instructions. I think these changes might improve them. Let me know what you think.
#1731