Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Put IdeResult in terms of Either, add ideError#1611

Open
Gurkenglas wants to merge1 commit intohaskell:master
base:master
Choose a base branch
Loading
fromGurkenglas:explore-1

Conversation

Gurkenglas
Copy link
Contributor

Let's try this again.

@Avi-D-coder
Copy link
Collaborator

Avi-D-coder commentedJan 27, 2020
edited
Loading

@Gurkenglas What is the motive for this change?
It is allot more concise.

@Gurkenglas
Copy link
ContributorAuthor

You have answered your question :3

@jneira
Copy link
Member

jneira commentedJan 28, 2020
edited
Loading

Thanks for the pr, i think the intent is good and i always like the prs that remove locs (the actual new type has its own advantages though).
However, as you surely already knows, we just have start a process of integration with ghcide so it is the actual main focus.
We will continue to fix bugs but we will prefer that the new code or internal refactorings go in that direction (see#1416 (comment)).

Avi-D-coder reacted with thumbs up emoji

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@Gurkenglas@Avi-D-coder@jneira

[8]ページ先頭

©2009-2025 Movatter.jp