This repository was archived by the owner on Oct 7, 2020. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork205
[WIP] Generate an "Apply all hints" hlint code action#1450
Open
alanz wants to merge1 commit intohaskell:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This commit generates it all the time, without checking if we actuallyhave any hints.
This seems to be affecting stand alone hints? Just from looking at the diff it’s not obvious how exactly though |
Uh oh!
There was an error while loading.Please reload this page.
| hlintActions = do | ||
| actions <- mapM mkHlintAction (filter validCommand diags) | ||
| applyAll <- mkApplyAllAction | ||
| return (catMaybes $ applyAll:actions) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Some clients like coc.vim have keybindings to apply the first code action, so would it make sense to return this last?
Suggested change
| return (catMaybes$applyAll:actions) | |
| return (catMaybes$ actions++ [applyAll]) |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit generates it all the time, without checking if we actually have any hints.
This is a possible alternative tohaskell/vscode-haskell#168
But it may be better to update the
CodeActionProviderinterface to provide all the diagnostics for the given Uri/plugin combo, which can then be checked. Except that it may be too much processing, given the frequency of request.