Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enables VCR support for generated standalone tag resource types#45642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
gdavison wants to merge5 commits intomain
base:main
Choose a base branch
Loading
fromtd-generated-tag-resource-vcr

Conversation

@gdavison
Copy link
Contributor

@gdavisongdavison commentedDec 17, 2025•
edited
Loading

Rollback Plan

If a change needs to be reverted, we will publish an updated version of the library.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

Description

Enables VCR support for generated standalone tag resource types

  • aws_dynamodb_tag
  • aws_ec2_tag
  • aws_ecs_tag
  • aws_transfer_tag

References

Output from Acceptance Testing

%make testacc PKG=dynamodb TESTS=TestAccDynamoDBTag_--- PASS: TestAccDynamoDBTag_disappears (36.66s)--- PASS: TestAccDynamoDBTag_basic (42.87s)--- PASS: TestAccDynamoDBTag_value (50.61s)--- PASS: TestAccDynamoDBTag_multipleTags (76.59s)--- PASS: TestAccDynamoDBTag_ResourceARN_tableReplica (299.43s)
%make testacc PKG=ec2 TESTS=TestAccEC2Tag_--- PASS: TestAccEC2Tag_basic (458.73s)--- PASS: TestAccEC2Tag_value (804.82s)--- PASS: TestAccEC2Tag_disappears (862.37s)
%make testacc PKG=ecs TESTS=TestAccECSTag_--- PASS: TestAccECSTag_disappears (27.42s)--- PASS: TestAccECSTag_basic (30.28s)--- PASS: TestAccECSTag_value (40.27s)--- PASS: TestAccECSTag_ResourceARN_batchComputeEnvironment (58.50s)
%make testacc PKG=transfer TESTS='TestAccTransfer_serial/Tag'--- PASS: TestAccTransfer_serial (742.90s)    --- PASS: TestAccTransfer_serial/Tag (742.90s)        --- PASS: TestAccTransfer_serial/Tag/System (192.98s)        --- PASS: TestAccTransfer_serial/Tag/basic (162.15s)        --- PASS: TestAccTransfer_serial/Tag/disappears (188.64s)        --- PASS: TestAccTransfer_serial/Tag/Value (199.13s)

@gdavisongdavison requested a review froma team as acode ownerDecember 17, 2025 22:43
@github-actions
Copy link
Contributor

Community Guidelines

This comment is added to every new Pull Request to provide quick reference to how the Terraform AWS Provider is maintained. Please review the information below, and thank you for contributing to the community that keeps the provider thriving! 🚀

Voting for Prioritization

  • Please vote on this Pull Request by adding a 👍reaction to the original post to help the community and maintainers prioritize it.
  • Please see ourprioritization guide for additional information on how the maintainers handle prioritization.
  • Pleasedo not leave +1 or other comments that do not add relevant new information or questions; they generate extra noise for others following the Pull Request and do not help prioritize the request.

Pull Request Authors

  • Review thecontribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • Whether or not the branch has been rebased willnot impact prioritization, but doing so is always a welcome surprise.

@github-actionsgithub-actionsbot added prioritizedPart of the maintainer teams immediate focus. To be addressed within the current quarter. testsPRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/ecsIssues and PRs that pertain to the ecs service. service/dynamodbIssues and PRs that pertain to the dynamodb service. service/transferIssues and PRs that pertain to the transfer service. tagsPertains to resource tagging. generatorsRelates to code generators. size/MManaged by automation to categorize the size of a PR. labelsDec 17, 2025
@gdavisongdavison marked this pull request as draftDecember 17, 2025 23:41
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

generatorsRelates to code generators.prioritizedPart of the maintainer teams immediate focus. To be addressed within the current quarter.service/dynamodbIssues and PRs that pertain to the dynamodb service.service/ecsIssues and PRs that pertain to the ecs service.service/transferIssues and PRs that pertain to the transfer service.size/MManaged by automation to categorize the size of a PR.tagsPertains to resource tagging.testsPRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gdavison
[8]ページ先頭
©2009-2025 Movatter.jp